From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Pawel Chmielewski <pawel.chmielewski@intel.com>,
Jonathan.Cameron@huawei.com, baohua@kernel.org,
bristot@redhat.com, bsegall@google.com, davem@davemloft.net,
dietmar.eggemann@arm.com, gal@nvidia.com,
gregkh@linuxfoundation.org, hca@linux.ibm.com,
jacob.e.keller@intel.com, jesse.brandeburg@intel.com,
jgg@nvidia.com, juri.lelli@redhat.com, kuba@kernel.org,
leonro@nvidia.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
linux@rasmusvillemoes.dk, mgorman@suse.de, mingo@redhat.com,
netdev@vger.kernel.org, peter@n8pjl.ca, peterz@infradead.org,
rostedt@goodmis.org, saeedm@nvidia.com, tariqt@nvidia.com,
tony.luck@intel.com, torvalds@linux-foundation.org,
ttoukan.linux@gmail.com, vincent.guittot@linaro.org,
vschneid@redhat.com
Subject: Re: [PATCH 1/1] ice: Change assigning method of the CPU affinity masks
Date: Wed, 8 Feb 2023 18:58:47 +0200 [thread overview]
Message-ID: <Y+PUx8M6mrsMilZg@smile.fi.intel.com> (raw)
In-Reply-To: <Y+PQOCHCh78aAcAm@yury-laptop>
On Wed, Feb 08, 2023 at 08:39:20AM -0800, Yury Norov wrote:
> On Wed, Feb 08, 2023 at 04:39:05PM +0100, Pawel Chmielewski wrote:
...
> > + v_idx = 0;
> > + for_each_numa_hop_mask(aff_mask, numa_node) {
> > + for_each_cpu_andnot(cpu, aff_mask, last_aff_mask)
> > + if (v_idx < vsi->num_q_vectors) {
> > + if (cpu_online(cpu))
> > + cpumask_set_cpu(cpu, &vsi->q_vectors[v_idx]->affinity_mask);
> > + v_idx++;
> > + }
> else
> goto out;
In this case the inverted conditional makes more sense:
if (v_idx >= vsi->num_q_vectors)
goto out;
if (cpu_online(cpu))
cpumask_set_cpu(cpu, &vsi->q_vectors[v_idx]->affinity_mask);
v_idx++;
(indentation level will be decreased).
> > + last_aff_mask = aff_mask;
> > + }
> > +
> out:
>
> > return 0;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-08 16:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 4:24 [PATCH RESEND 0/9] sched: cpumask: improve on cpumask_local_spread() locality Yury Norov
2023-01-21 4:24 ` [PATCH 1/9] lib/find: introduce find_nth_and_andnot_bit Yury Norov
2023-01-21 4:24 ` [PATCH 2/9] cpumask: introduce cpumask_nth_and_andnot Yury Norov
2023-01-21 4:24 ` [PATCH 3/9] sched: add sched_numa_find_nth_cpu() Yury Norov
2023-02-03 0:58 ` Chen Yu
2023-02-07 5:09 ` Jakub Kicinski
2023-02-07 10:29 ` Valentin Schneider
2023-02-17 1:39 ` Yury Norov
2023-02-17 11:11 ` Andy Shevchenko
2023-02-20 19:46 ` Jakub Kicinski
2023-01-21 4:24 ` [PATCH 4/9] cpumask: improve on cpumask_local_spread() locality Yury Norov
2023-01-21 4:24 ` [PATCH 5/9] lib/cpumask: reorganize cpumask_local_spread() logic Yury Norov
2023-01-21 4:24 ` [PATCH 6/9] sched/topology: Introduce sched_numa_hop_mask() Yury Norov
2023-01-21 4:24 ` [PATCH 7/9] sched/topology: Introduce for_each_numa_hop_mask() Yury Norov
2023-01-21 4:24 ` [PATCH 8/9] net/mlx5e: Improve remote NUMA preferences used for the IRQ affinity hints Yury Norov
2023-01-21 4:24 ` [PATCH 9/9] lib/cpumask: update comment for cpumask_local_spread() Yury Norov
2023-01-22 12:57 ` [PATCH RESEND 0/9] sched: cpumask: improve on cpumask_local_spread() locality Tariq Toukan
2023-01-23 9:57 ` Valentin Schneider
2023-01-29 8:07 ` Tariq Toukan
2023-01-30 20:22 ` Jakub Kicinski
2023-02-02 17:33 ` Jakub Kicinski
2023-02-02 17:37 ` Yury Norov
2023-02-08 2:25 ` Jakub Kicinski
2023-02-08 4:20 ` patchwork-bot+netdevbpf
2023-02-08 15:39 ` [PATCH 1/1] ice: Change assigning method of the CPU affinity masks Pawel Chmielewski
[not found] ` <CAH-L+nO+KyzPSX_F0fh+9i=0rW1hoBPFTGbXc1EX+4MGYOR1kA@mail.gmail.com>
2023-02-08 16:08 ` Andy Shevchenko
2023-02-08 16:39 ` Yury Norov
2023-02-08 16:58 ` Andy Shevchenko [this message]
2023-02-08 19:11 ` kernel test robot
2023-02-09 2:41 ` Philip Li
2023-02-08 19:22 ` kernel test robot
2023-02-08 23:21 ` Jakub Kicinski
2023-02-09 5:14 ` kernel test robot
2023-02-16 14:54 ` [PATCH v2 " Pawel Chmielewski
2023-02-16 15:14 ` Andy Shevchenko
2023-02-16 15:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+PUx8M6mrsMilZg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=baohua@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=davem@davemloft.net \
--cc=dietmar.eggemann@arm.com \
--cc=gal@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgg@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.chmielewski@intel.com \
--cc=peter@n8pjl.ca \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=ttoukan.linux@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).