From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B69A0C4332F for ; Wed, 19 Oct 2022 11:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbiJSLhk (ORCPT ); Wed, 19 Oct 2022 07:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230376AbiJSLhM (ORCPT ); Wed, 19 Oct 2022 07:37:12 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8F21108273; Wed, 19 Oct 2022 04:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666178121; x=1697714121; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=IM/miqYiKsUKovYDNaQ0wtYbr7tjTO2nvi5P+UfcMOA=; b=gynb6KYtZQiEjGcaaJ5vMLqVPuAm7bB5tayluvB5ejyQDlX9sMli+bT8 W9fQbIOei4OYqHNfNRZeNBTwd02NGtz5Jii+o7fk5ULYi2RIbyzYKei5n 5r3IJ+brDETCq+FlW2grk39pA3CNj0Vpwk1BZhlJ+2sTGTiSeC4otVZ96 SbRm5onEvO9ZWe8eY6NOX0c+KbL8/FZILeNFPQltBdIpRNowgZfFMMe3t Gff8Md2nGF6fsjHW4pqFAQGarY7RFTEQdmmcjWJ4DtUrK3eV9VD0SMk79 XE1tBhZSf8+gmorUTfDXxYWLsC1jlOB1YBL70o2FqfRisx11S/7fBwxx2 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="303996254" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="303996254" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 04:11:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="580289133" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="580289133" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 19 Oct 2022 04:11:35 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ol6yz-009pAZ-2E; Wed, 19 Oct 2022 14:11:33 +0300 Date: Wed, 19 Oct 2022 14:11:33 +0300 From: Andy Shevchenko To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/44] serial: sc16is7xx: Use uart_xmit_advance() Message-ID: References: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> <20221019091151.6692-6-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221019091151.6692-6-ilpo.jarvinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 19, 2022 at 12:11:12PM +0300, Ilpo Järvinen wrote: > Take advantage of the new uart_xmit_advance() helper. Reviewed-by: Andy Shevchenko > Signed-off-by: Ilpo Järvinen > --- > drivers/tty/serial/sc16is7xx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > index 524921360ca7..39f92eb1e698 100644 > --- a/drivers/tty/serial/sc16is7xx.c > +++ b/drivers/tty/serial/sc16is7xx.c > @@ -686,13 +686,10 @@ static void sc16is7xx_handle_tx(struct uart_port *port) > } > to_send = (to_send > txlen) ? txlen : to_send; > > - /* Add data to send */ > - port->icount.tx += to_send; > - > /* Convert to linear buffer */ > for (i = 0; i < to_send; ++i) { > s->buf[i] = xmit->buf[xmit->tail]; > - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1); > + uart_xmit_advance(port, 1); > } > > sc16is7xx_fifo_write(port, to_send); > -- > 2.30.2 > -- With Best Regards, Andy Shevchenko