From: Christoph Hellwig <hch@infradead.org>
To: Dawei Li <set_pte_at@outlook.com>
Cc: axboe@kernel.dk, tj@kernel.org, paolo.valente@linaro.org,
linux-block@vger.kernel.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: Add helper for queue_flags bit test
Date: Mon, 17 Oct 2022 00:47:18 -0700 [thread overview]
Message-ID: <Y00IhghhGgVQBknL@infradead.org> (raw)
In-Reply-To: <TYCP286MB232392B1D23662DE81B0D2D5CA239@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
> if (op_is_flush(bio->bi_opf) &&
> - !test_bit(QUEUE_FLAG_WC, &q->queue_flags)) {
> + !blk_queue_wb_cached(q)) {
The formatting is wrong here. And I really think these helpers do
nothing but obsfucating the code. Now instead of a grep telling
me exactly what is going on I now need to walk through the macro
first. (nevermind that this particular one is also horribly misnamed).
next prev parent reply other threads:[~2022-10-17 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221011145246.8656-1-set_pte_at@outlook.com>
2022-10-11 14:52 ` [PATCH 1/2] block: Add helper for queue_flags bit test Dawei Li
2022-10-17 7:47 ` Christoph Hellwig [this message]
2022-10-11 14:52 ` [PATCH 2/2] block: Make refcnt of bfq_group/bfq_queue atomic Dawei Li
2022-10-17 8:28 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y00IhghhGgVQBknL@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=set_pte_at@outlook.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).