From: Sean Christopherson <seanjc@google.com>
To: Santosh Shukla <santosh.shukla@amd.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
mlevitsk@redhat.com, mail@maciej.szmigiero.name
Subject: Re: [PATCHv4 0/8] Virtual NMI feature
Date: Mon, 10 Oct 2022 15:51:41 +0000 [thread overview]
Message-ID: <Y0Q/jVzFz3MoP26d@google.com> (raw)
In-Reply-To: <b8a6ac33-eb39-5bf3-db55-a2189d67d202@amd.com>
On Mon, Oct 10, 2022, Santosh Shukla wrote:
>
>
> On 10/7/2022 12:10 AM, Sean Christopherson wrote:
> > On Mon, Aug 29, 2022, Santosh Shukla wrote:
> >> If NMI virtualization enabled and NMI_INTERCEPT bit is unset
> >> then HW will exit with #INVALID exit reason.
> >>
> >> To enable the VNMI capability, Hypervisor need to program
> >> V_NMI_ENABLE bit 1.
> >>
> >> The presence of this feature is indicated via the CPUID function
> >> 0x8000000A_EDX[25].
> >
> > Until there is publicly available documentation, I am not going to review this
> > any further. This goes for all new features, e.g. PerfMonv2[*]. I understand
> > the need and desire to get code merged far in advance of hardware being available,
> > but y'all clearly have specs, i.e. this is a very solvable problem. Throw all the
> > disclaimers you want on the specs to make it abundantly clear that they are for
> > preview purposes or whatever, but reviewing KVM code without a spec just doesn't
> > work for me.
> >
>
> Sure Sean.
>
> I am told that the APM should be out in the next couple of weeks.
Probably too late to be of much value for virtual NMI support, but for future
features, it would be very helpful to release "preview" documentation ASAP so that
we don't have to wait for the next APM update, which IIUC only happens ~2 times a
year.
next prev parent reply other threads:[~2022-10-10 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 10:08 [PATCHv4 0/8] Virtual NMI feature Santosh Shukla
2022-08-29 10:08 ` [PATCHv4 1/8] x86/cpu: Add CPUID feature bit for VNMI Santosh Shukla
2022-08-31 23:42 ` Jim Mattson
2022-09-01 12:45 ` Shukla, Santosh
2022-09-01 17:43 ` Jim Mattson
2022-09-05 7:49 ` Shukla, Santosh
2022-08-29 10:08 ` [PATCHv4 2/8] KVM: SVM: Add VNMI bit definition Santosh Shukla
2022-08-29 10:08 ` [PATCHv4 3/8] KVM: SVM: Add VNMI support in get/set_nmi_mask Santosh Shukla
2022-08-29 10:08 ` [PATCHv4 4/8] KVM: SVM: Report NMI not allowed when Guest busy handling VNMI Santosh Shukla
2022-08-29 10:08 ` [PATCHv4 5/8] KVM: SVM: Add VNMI support in inject_nmi Santosh Shukla
2022-08-29 10:08 ` [PATCHv4 6/8] KVM: nSVM: implement nested VNMI Santosh Shukla
2022-08-29 10:08 ` [PATCHv4 7/8] KVM: nSVM: emulate VMEXIT_INVALID case for " Santosh Shukla
2022-08-29 10:08 ` [PATCHv4 8/8] KVM: SVM: Enable VNMI feature Santosh Shukla
2022-10-06 18:40 ` [PATCHv4 0/8] Virtual NMI feature Sean Christopherson
2022-10-10 5:46 ` Santosh Shukla
2022-10-10 15:51 ` Sean Christopherson [this message]
2022-10-16 5:49 ` Santosh Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0Q/jVzFz3MoP26d@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).