From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8027AC433FE for ; Tue, 11 Oct 2022 05:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229538AbiJKFp7 (ORCPT ); Tue, 11 Oct 2022 01:45:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiJKFp4 (ORCPT ); Tue, 11 Oct 2022 01:45:56 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC4AD4D15C; Mon, 10 Oct 2022 22:45:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 24D8F80FE; Tue, 11 Oct 2022 05:37:08 +0000 (UTC) Date: Tue, 11 Oct 2022 08:45:54 +0300 From: Tony Lindgren To: Dmitry Torokhov Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] ARM: dts: omap3-n900: fix LCD reset line polarity Message-ID: References: <20221004213503.848262-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221004213503.848262-1-dmitry.torokhov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Dmitry Torokhov [221004 21:26]: > The LCD driver (panel-sony-acx565akm), when probing, starts with line > driven low, and then toggles it to high and keeps it there. Also, the > line is driven low when powering off the device, and ls released when > powering it back on. This means that the reset line should be described > as "active low" in DTS. This will be important when the driver is > converted to gpiod API which respects the polarity declared in DTS. We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case. It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver. Regards, Tony