From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>, Shawn Tu <shawnx.tu@intel.com>,
Jacopo Mondi <jacopo@jmondi.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2 5/5] media: i2c: ov5645: Call ov5645_entity_init_cfg() before registering the subdev
Date: Sat, 15 Oct 2022 09:26:36 +0300 [thread overview]
Message-ID: <Y0pSnKREW0pjtPYI@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221014183459.181567-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Prabhakar,
Thank you for the patch.
On Fri, Oct 14, 2022 at 07:34:59PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Make sure we call ov5645_entity_init_cfg() before registering the subdev
> to make sure default formats are set up.
>
> Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
If you have a few spare cycles, it would be even better to convert the
driver to the subdev active state API :-) You could then drop this call
entirely.
> ---
> v1->v2
> * New patch
> ---
> drivers/media/i2c/ov5645.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
> index b3825294aaf1..14bcc6e42dd2 100644
> --- a/drivers/media/i2c/ov5645.c
> +++ b/drivers/media/i2c/ov5645.c
> @@ -1212,6 +1212,8 @@ static int ov5645_probe(struct i2c_client *client)
> goto err_pm_runtime;
> }
>
> + ov5645_entity_init_cfg(&ov5645->sd, NULL);
> +
> ret = v4l2_async_register_subdev(&ov5645->sd);
> if (ret < 0) {
> dev_err(dev, "could not register v4l2 device\n");
> @@ -1224,8 +1226,6 @@ static int ov5645_probe(struct i2c_client *client)
> pm_runtime_use_autosuspend(dev);
> pm_runtime_put_autosuspend(dev);
>
> - ov5645_entity_init_cfg(&ov5645->sd, NULL);
> -
> return 0;
>
> err_pm_runtime:
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-10-15 6:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 18:34 [PATCH v2 0/5] media: i2c: ov5645 driver enhancements Prabhakar
2022-10-14 18:34 ` [PATCH v2 1/5] media: dt-bindings: ov5645: Convert OV5645 binding to a schema Prabhakar
2022-10-14 21:00 ` Rob Herring
2022-10-14 21:05 ` Rob Herring
2022-10-14 21:27 ` Lad, Prabhakar
2022-10-14 21:40 ` Rob Herring
2022-10-15 5:54 ` Laurent Pinchart
2022-10-15 13:17 ` Krzysztof Kozlowski
2022-10-17 7:43 ` Lad, Prabhakar
2022-10-26 16:56 ` Rob Herring
2022-10-14 18:34 ` [PATCH v2 2/5] media: i2c: ov5645: Use runtime PM Prabhakar
2022-10-14 19:18 ` Sakari Ailus
2022-10-14 21:30 ` Lad, Prabhakar
2022-10-15 6:05 ` Laurent Pinchart
2022-10-15 6:25 ` Laurent Pinchart
2022-10-26 12:07 ` Lad, Prabhakar
2022-10-27 11:20 ` Sakari Ailus
2022-10-27 12:01 ` Lad, Prabhakar
2022-10-27 12:47 ` Sakari Ailus
2022-10-27 16:32 ` Lad, Prabhakar
2022-10-27 18:37 ` Sakari Ailus
2022-10-28 21:05 ` Lad, Prabhakar
2022-10-31 14:25 ` Sakari Ailus
2022-10-31 16:10 ` Lad, Prabhakar
2022-10-14 18:34 ` [PATCH v2 3/5] media: i2c: ov5645: Drop empty comment Prabhakar
2022-10-15 6:05 ` Laurent Pinchart
2022-10-14 18:34 ` [PATCH v2 4/5] media: i2c: ov5645: Return zero for s_stream(0) Prabhakar
2022-10-15 6:25 ` Laurent Pinchart
2022-10-15 21:35 ` Sakari Ailus
2022-10-15 23:23 ` Laurent Pinchart
2022-10-16 20:19 ` Sakari Ailus
2022-10-16 21:03 ` Laurent Pinchart
2022-10-17 7:12 ` Sakari Ailus
2022-10-17 7:40 ` Lad, Prabhakar
2022-10-14 18:34 ` [PATCH v2 5/5] media: i2c: ov5645: Call ov5645_entity_init_cfg() before registering the subdev Prabhakar
2022-10-15 6:26 ` Laurent Pinchart [this message]
2022-10-26 11:59 ` Lad, Prabhakar
2022-10-14 18:40 ` [PATCH v2 0/5] media: i2c: ov5645 driver enhancements Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0pSnKREW0pjtPYI@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).