From: Huang Rui <ray.huang@amd.com>
To: "Meng, Li (Jassmine)" <Li.Meng@amd.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
"Sharma, Deepak" <Deepak.Sharma@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Limonciello, Mario" <Mario.Limonciello@amd.com>,
"Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
"Yuan, Perry" <Perry.Yuan@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Borislav Petkov <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 0/4] Add tbench/gitsource new test cases for amd-pstate-ut
Date: Mon, 17 Oct 2022 10:33:53 +0800 [thread overview]
Message-ID: <Y0y/EeA5uWTFWLHJ@amd.com> (raw)
In-Reply-To: <20220914061105.1982477-1-li.meng@amd.com>
On Wed, Sep 14, 2022 at 02:11:01PM +0800, Meng, Li (Jassmine) wrote:
> Hi all:
>
> First, we modify amd-pstate-ut.sh to basic.sh as a basic test, mainly for
> AMD P-State kernel drivers. The purpose of this modification is to
> facilitate the subsequent addition of gitsource, tbench and other tests.
> You can test specific functions by specifying test cases.
> Default test all cases, include basic, tbench and gitsource etc.
>
> Secondly, add tbench.sh trigger the tbench testing and monitor the cpu
> information.
> 1) Download and install tbench codes.
> 2) Run tbench benchmark on specific governors, ondemand or schedutil.
> 3) Run tbench benchmark comparative test on acpi-cpufreq kernel driver.
> 4) Get desire performance, frequency, load by perf.
> 5) Get power consumption and throughput by amd_pstate_trace.py.
> 6) Analyse test results and save it in file selftest.tbench.csv.
> 7) Plot png images about performance, energy and performance per watt
> for each test.
>
> Third, add gitsource.sh trigger the gitsource testing and monitor the cpu
> information.
> 1) Download and tar gitsource codes.
> 2) Run gitsource benchmark on specific governors, ondemand or schedutil.
> 3) Run tbench benchmark comparative test on acpi-cpufreq kernel driver.
> 4) Get desire performance, frequency, load by perf.
> 5) Get power consumption and throughput by amd_pstate_trace.py.
> 6) Get run time by /usr/bin/time.
> 7) Analyse test results and save it in file selftest.gitsource.csv.
> 8) Plot png images about time, energy and performance per watt
> for each test.
>
The cover letter won't be included into kernel commit. Above steps
are even clearer than the original patch commit message. So I suggest you
can move them into related commit log.
TBench steps -> Patch 2
Gitsource steps -> Patch 3
Thanks,
Ray
> Finally, modify rst document to introduce test steps and results etc.
>
> See patch series in below git repo:
> V1:https://lore.kernel.org/lkml/20220706073622.672135-1-li.meng@amd.com/
> V2:https://lore.kernel.org/lkml/20220804054414.1510764-1-li.meng@amd.com/
>
> Changes from V1->V2:
> - selftests: amd-pstate: basic
> - - delete main.sh and merge funtions into run.sh
> - selftests: amd-pstate: tbench
> - - modify ppw to performance per watt for tbench.
> - - add comments for performance per watt for tbench.
> - - add comparative test on acpi-cpufreq for tbench.
> - - calculate drop between amd-pstate and acpi-cpufreq etc.
> - - plot images about perfrmance,energy and ppw for tbench.
> - selftests: amd-pstate: gitsource
> - - modify ppw to performance per watt for gitsource.
> - - add comments for performance per watt for gitsource.
> - - add comparative test on acpi-cpufreq for gitsource.
> - - calculate drop between amd-pstate and acpi-cpufreq etc.
> - - plot images about perfrmance,energy and ppw for gitsource.
> - Documentation: amd-pstate:
> - - modify rst doc, introduce comparative test etc.
>
> Changes from V2->V3:
> - selftests: amd-pstate:
> - - reduce print logs for governor.
> - - add a check to see if tbench and the perf tools are already installed.
> - - install tbench package from apt or yum.
> - - correct spelling errors from comprison to comparison.
>
> Thanks,
> Jasmine
>
> Meng Li (4):
> selftests: amd-pstate: Modify amd-pstate-ut.sh to basic.sh.
> selftests: amd-pstate: Trigger tbench benchmark and test cpus
> selftests: amd-pstate: Trigger gitsource benchmark and test cpus
> Documentation: amd-pstate: Add tbench and gitsource test introduction
>
> Documentation/admin-guide/pm/amd-pstate.rst | 192 ++++++++-
> tools/testing/selftests/amd-pstate/Makefile | 11 +-
> .../selftests/amd-pstate/amd-pstate-ut.sh | 56 ---
> tools/testing/selftests/amd-pstate/basic.sh | 38 ++
> .../testing/selftests/amd-pstate/gitsource.sh | 345 ++++++++++++++++
> tools/testing/selftests/amd-pstate/run.sh | 387 ++++++++++++++++++
> tools/testing/selftests/amd-pstate/tbench.sh | 334 +++++++++++++++
> 7 files changed, 1287 insertions(+), 76 deletions(-)
> delete mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh
> create mode 100755 tools/testing/selftests/amd-pstate/basic.sh
> create mode 100755 tools/testing/selftests/amd-pstate/gitsource.sh
> create mode 100755 tools/testing/selftests/amd-pstate/run.sh
> create mode 100755 tools/testing/selftests/amd-pstate/tbench.sh
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-10-17 2:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 6:11 [PATCH V3 0/4] Add tbench/gitsource new test cases for amd-pstate-ut Meng Li
2022-09-14 6:11 ` [PATCH V3 1/4] selftests: amd-pstate: Modify amd-pstate-ut.sh to basic.sh Meng Li
2022-10-17 2:48 ` Huang Rui
2022-09-14 6:11 ` [PATCH V3 2/4] selftests: amd-pstate: Trigger tbench benchmark and test cpus Meng Li
2022-10-17 4:59 ` Huang Rui
2022-09-14 6:11 ` [PATCH V3 3/4] selftests: amd-pstate: Trigger gitsource " Meng Li
2022-10-17 5:16 ` Huang Rui
2022-09-14 6:11 ` [PATCH V3 4/4] Documentation: amd-pstate: Add tbench and gitsource test introduction Meng Li
2022-10-17 5:27 ` Huang Rui
2022-10-17 2:33 ` Huang Rui [this message]
2022-10-17 5:34 ` [PATCH V3 0/4] Add tbench/gitsource new test cases for amd-pstate-ut Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0y/EeA5uWTFWLHJ@amd.com \
--to=ray.huang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=skhan@linuxfoundation.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).