From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FA6FA3742 for ; Mon, 31 Oct 2022 10:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230404AbiJaK1A (ORCPT ); Mon, 31 Oct 2022 06:27:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbiJaK0x (ORCPT ); Mon, 31 Oct 2022 06:26:53 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF94CDF83; Mon, 31 Oct 2022 03:26:51 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7cf329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7cf:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2DF351EC0535; Mon, 31 Oct 2022 11:26:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667212010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=E7+K2agDo3PWDiJqVGMFuc1n6P62g6uovokW/fknxaA=; b=Zk9hoPSpjGxLc164VkfRjc3kxF3H5rdM5S2OIk8Sm2KSIfuJ3RKiVpKzNYmGfHeTViGApG amin5PfneXFixhMrbpF8F+8UQ4rwNPUNZzpWdq8cpBNHEjkeSFJw/R9BEUjMzD4sktnPGs nzTzehkkbh1DZFK28+khZ7EQcOGLWok= Date: Mon, 31 Oct 2022 11:26:44 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Smita.KoralahalliChannabasappa@amd.com, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org Subject: Re: [PATCH] EDAC/mc_sysfs: Increase legacy channel support to 12 Message-ID: References: <20221018153630.14664-1-yazen.ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221018153630.14664-1-yazen.ghannam@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 10:36:30AM -0500, Yazen Ghannam wrote: > Newer AMD systems, such as Genoa, can support up to 12 channels per EDAC > "mc" device. These are detected by the device's EDAC module, and the > current EDAC interface is properly enumerated. However, the legacy EDAC > sysfs interface provides device attributes only for channels 0 to 7. > Therefore, channels 8 to 11 will not be visible in the legacy interface. > This was overlooked in the initial support for AMD Genoa. > > Add additional device attributes so that up to 12 channels are visible > in the legacy EDAC sysfs interface. > > Ignore checkpatch warnings about "Symbolic permissions" to maintain > coding style. > > Fixes: e2be5955a886 ("EDAC/amd64: Add support for AMD Family 19h Models 10h-1Fh and A0h-AFh") > Signed-off-by: Yazen Ghannam > Cc: > --- > drivers/edac/edac_mc_sysfs.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette