From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
linux-kernel@vger.kernel.org, "Kees Cook" <keescook@chromium.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Jaegeuk Kim" <jaegeuk@kernel.org>,
"Richard Weinberger" <richard@nod.at>,
"Darrick J . Wong" <djwong@kernel.org>,
"SeongJae Park" <sj@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Helge Deller" <deller@gmx.de>,
netdev@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mmc@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [PATCH v1 0/5] convert tree to get_random_u32_{below,above,between}()
Date: Mon, 24 Oct 2022 18:43:09 +0200 [thread overview]
Message-ID: <Y1bAnU4pCczkw5j8@zx2c4.com> (raw)
In-Reply-To: <Y1WtAZfciG1z2CC7@mit.edu>
On Sun, Oct 23, 2022 at 05:07:13PM -0400, Theodore Ts'o wrote:
> On Fri, Oct 21, 2022 at 11:03:22PM -0700, Jakub Kicinski wrote:
> > On Sat, 22 Oct 2022 07:47:06 +0200 Jason A. Donenfeld wrote:
> > > On Fri, Oct 21, 2022 at 10:32:42PM -0700, Jakub Kicinski wrote:
> > > > But whatever. I mean - hopefully there aren't any conflicts in the ~50
> > > > networking files you touch. I just wish that people didn't pipe up with
> > > > the tree wide changes right after the merge window. Feels like the
> > > > worst possible timing.
> > >
> > > Oh, if the timing is what makes this especially worrisome, I have
> > > no qualms about rebasing much later, and reposting this series then.
> > > I'll do that.
> >
> > Cool, thanks! I promise to not be grumpy if you repost around rc6 :)
>
> One way of making things less painful for the stable branch and for
> the upstream branch is to *add* new helpers instead of playing
> replacement games like s/prandom_u32_max/get_random_u32_below/. This
> is what causes the patch conflict problems.
>
> One advantage of at least adding the new functions to the stable
> branches, even if we don't do the wholesale replacement, is that it
That's a good idea. I'll also save the removal commit, anyhow, for a
separate thing at the end of 6.2 rc1, so that -next doesn't have issues
either. That's how things wound up going down for the first tranche of
these, and that worked well.
Jason
next prev parent reply other threads:[~2022-10-24 18:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 1:43 [PATCH v1 0/5] convert tree to get_random_u32_{below,above,between}() Jason A. Donenfeld
2022-10-22 1:43 ` [PATCH v1 1/5] treewide: use get_random_u32_below() instead of deprecated function Jason A. Donenfeld
2022-10-22 2:25 ` Darrick J. Wong
2022-10-22 18:44 ` SeongJae Park
2022-10-22 1:44 ` [PATCH v1 2/5] prandom: remove prandom_u32_max() Jason A. Donenfeld
2022-10-22 1:44 ` [PATCH v1 3/5] random: add helpers for random numbers with given floor or range Jason A. Donenfeld
2022-11-14 18:04 ` Yann Droneaud
2022-11-14 18:38 ` Jason A. Donenfeld
2022-11-15 8:42 ` Yann Droneaud
2022-11-16 0:25 ` Jason A. Donenfeld
2022-10-22 1:44 ` [PATCH v1 4/5] treewide: use get_random_u32_{above,below}() instead of manual loop Jason A. Donenfeld
2022-10-22 1:44 ` [PATCH v1 5/5] treewide: use get_random_u32_between() when possible Jason A. Donenfeld
2022-10-22 3:55 ` [PATCH v1 0/5] convert tree to get_random_u32_{below,above,between}() Jakub Kicinski
2022-10-22 4:23 ` Jason A. Donenfeld
2022-10-22 5:32 ` Jakub Kicinski
2022-10-22 5:47 ` Jason A. Donenfeld
2022-10-22 6:03 ` Jakub Kicinski
2022-10-23 21:07 ` Theodore Ts'o
2022-10-24 16:43 ` Jason A. Donenfeld [this message]
2022-10-22 10:21 ` Greg Kroah-Hartman
2022-10-24 16:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1bAnU4pCczkw5j8@zx2c4.com \
--to=jason@zx2c4.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=christoph.boehmwalder@linbit.com \
--cc=deller@gmx.de \
--cc=djwong@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=richard@nod.at \
--cc=sakari.ailus@linux.intel.com \
--cc=sj@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).