linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gautam Menghani <gautammenghani201@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: rostedt@goodmis.org, mhiramat@kernel.org, zokeefe@google.com,
	shy828301@gmail.com, vbabka@suse.cz, david@redhat.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v2] mm/khugepaged: add tracepoint to collapse_file()
Date: Tue, 25 Oct 2022 10:35:11 +0530	[thread overview]
Message-ID: <Y1duhy5kbhLoMqWO@biggie> (raw)
In-Reply-To: <20221024131706.3d58bd92c332684386c7df13@linux-foundation.org>

On Mon, Oct 24, 2022 at 01:17:06PM -0700, Andrew Morton wrote:
> On Mon, 24 Oct 2022 23:05:58 +0530 Gautam Menghani <gautammenghani201@gmail.com> wrote:
> 
> > In the file mm/khugepaged.c, a TODO in the function collapse_file() asks
> > to add tracepoints. Add the tracepoint named "mm_khugepaged_collapse_file".
> 
> This isn't a very satisfying explanation for changing the kernel.  Maybe
> the comment is stale are this tracepoint is unneeded.
> 
> Please explain afresh how this addition benefits kernel users?
> 
The function collapse_file() is called by the function hpage_collapse_scan_file(). 
Without a tracepoint in collapse_file(), we won't know if it was called or not and as a result,
we also won't know if it returned successfully or not. Also, as Zach mentioned earlier [1]:

there are a few scan result codes that overlap between hpage_collapse_scan_file() and those
possibly returned in collapse_file() such that, if we only have the one tracepoint in 
hpage_collapse_scan_file(), it could be ambiguous what callsite the error path stemmed from.

[1]:https://lore.kernel.org/lkml/CAAa6QmSKtj6T2dW1tkg5_HVj2+rXj5inOLdEzr0MkJzQxxcPXQ@mail.gmail.com/

Please do let me know if a v3 is needed.

Thanks,
Gautam

  reply	other threads:[~2022-10-25  5:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 17:35 [PATCH v2] mm/khugepaged: add tracepoint to collapse_file() Gautam Menghani
2022-10-24 20:17 ` Andrew Morton
2022-10-25  5:05   ` Gautam Menghani [this message]
2022-10-25 18:20     ` Zach O'Keefe
2022-10-26  4:53       ` Gautam Menghani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1duhy5kbhLoMqWO@biggie \
    --to=gautammenghani201@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shy828301@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=zokeefe@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).