From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Vidya Sagar <vidyas@nvidia.com>,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
robh@kernel.org, kw@linux.com, bhelgaas@google.com,
treding@nvidia.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
Date: Wed, 26 Oct 2022 14:33:31 +0200 [thread overview]
Message-ID: <Y1kpG0l05uMueM9Y@lpieralisi> (raw)
In-Reply-To: <8670e757-7275-57eb-3f5c-0a21ba354e37@nvidia.com>
On Wed, Oct 26, 2022 at 12:39:13PM +0100, Jon Hunter wrote:
> Hi Lorenzo,
>
> On 18/10/2022 17:43, Bjorn Helgaas wrote:
> > On Tue, Oct 18, 2022 at 07:21:54AM +0100, Jon Hunter wrote:
> > > Hi Bjorn,
> > >
> > > On 13/09/2022 11:12, Vidya Sagar wrote:
> > > > Some of the platforms (like Tegra194 and Tegra234) have open slots and
> > > > not having an endpoint connected to the slot is not an error.
> > > > So, changing the macro from dev_err to dev_info to log the event.
> > > >
> > > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > > > ---
> > > > drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > > > index 650a7f22f9d0..25154555aa7a 100644
> > > > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > > > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > > > @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
> > > > }
> > > > if (retries >= LINK_WAIT_MAX_RETRIES) {
> > > > - dev_err(pci->dev, "Phy link never came up\n");
> > > > + dev_info(pci->dev, "Phy link never came up\n");
> > > > return -ETIMEDOUT;
> > > > }
> > >
> > >
> > > Are you OK to take this change?
> >
> > When this came up, Lorenzo was in the middle of a big move and I was
> > covering for him while he was unavailable. But he's back, and I'm
> > sure he will resolve this soon.
> >
> > Personally I'm OK either way.
> >
> > Bjorn
>
>
> Can we come to a conclusion on this?
>
> We have tests that fail when errors/warning messages are reported. We can
> choose to ignore these errors, but given that this is not an error in this
> case, we were thinking it is better to make it informational.
I understood.
We are at v6.1-rc2, this patch is not a fix, we will handle it for the
v6.2 merge window.
Thanks,
Lorenzo
next prev parent reply other threads:[~2022-10-26 12:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 10:12 [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging Vidya Sagar
2022-09-13 16:51 ` Manivannan Sadhasivam
2022-09-13 17:00 ` Jon Hunter
2022-09-13 20:07 ` Bjorn Helgaas
2022-09-14 6:24 ` Manivannan Sadhasivam
2022-09-14 11:02 ` Vidya Sagar
2022-09-14 11:18 ` Manivannan Sadhasivam
2022-09-14 11:25 ` Jon Hunter
2022-09-14 11:43 ` Manivannan Sadhasivam
2022-09-14 11:52 ` Jon Hunter
2022-09-14 12:44 ` Krzysztof Wilczyński
2022-09-14 13:45 ` Manivannan Sadhasivam
2022-09-14 14:52 ` Krzysztof Wilczyński
2022-09-14 15:11 ` Jon Hunter
2022-09-15 14:16 ` Rob Herring
2022-09-15 14:52 ` Manivannan Sadhasivam
2022-09-26 10:29 ` Vidya Sagar
2022-10-03 11:25 ` Vidya Sagar
2022-10-04 12:53 ` Rob Herring
2022-10-10 6:02 ` Vidya Sagar
2022-10-26 18:06 ` Rob Herring
2022-10-27 9:39 ` Lorenzo Pieralisi
2022-10-27 11:03 ` Manivannan Sadhasivam
2022-09-14 6:12 ` Manivannan Sadhasivam
2022-09-15 10:44 ` Manivannan Sadhasivam
2022-10-18 6:21 ` Jon Hunter
2022-10-18 16:43 ` Bjorn Helgaas
2022-10-26 11:39 ` Jon Hunter
2022-10-26 12:33 ` Lorenzo Pieralisi [this message]
2022-10-27 9:55 ` Ben Dooks
2022-10-27 11:05 ` Manivannan Sadhasivam
2022-11-10 15:40 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1kpG0l05uMueM9Y@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).