From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD28EC433FE for ; Wed, 26 Oct 2022 15:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233876AbiJZPFC (ORCPT ); Wed, 26 Oct 2022 11:05:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234149AbiJZPE6 (ORCPT ); Wed, 26 Oct 2022 11:04:58 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4663A5AC5D for ; Wed, 26 Oct 2022 08:04:54 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id f140so15581171pfa.1 for ; Wed, 26 Oct 2022 08:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dQ34jIpbpDucuLY8ATaIgOEFfc2/bsjXaMGrXhKJTd8=; b=r9rdQmYlzGyPfFKt7mca+0RebQHXPMm0Jybf4cXSyhtKsjhZ+vYs1m14e9WHSkUTt3 YWQNyvAN/JH+tH++h4hziuYXWw5MpFcbTtiyIZ9RURAhu0fr1qmNhuFMqhjM4dxti7h1 tMoGdCPRgd/zQUoxo+TpbritmQbksQFyO6swiSQwjHmvlNet3i/DCd5L/TobtDoLrrLZ IpdqAt7CY4brrc5ixOS+fcseOqG+jKdWzcRSvXJYDqxRJW5hiuIsNdN/z5R9GSjF7wY3 M8ybn5N2mNykI0+59Er0i6f7qP8q/sfAjwxqz1mCPBmUTqUwZuwggs5zn3PXlI+hoOes DfOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dQ34jIpbpDucuLY8ATaIgOEFfc2/bsjXaMGrXhKJTd8=; b=uq1TfHSicc0/6yrYy0i76GQv3QuUlFV/59sa8ADbu2Sf2N1qNPonNqpZ0syFeMf+fs s2CHjsWZac6DWpYzjQ8v3h3VyNQ8/zNxxm3Gxtn60rvpYX1/dvFgQC+fQSwG7JI0gn9a wfeQAYwBu8Hd4c8ff6ybeNVZyt+7P4A7WXIDA+74ygSYQnZ0ImVzsF/Mx9hI6Njuzqja bfCJStuWR7vtJuL63Kr6VypPfBVqSCnhNoXdKBzC6iXBG97dY2ka+DwUN+5J4uMEGg4e UgxJtyJ0SU87t1yYxlYfAxCc+FSOPJfTqXRahBWftcauxREbVQtnRSL8kwRxb89geMQ9 KlEg== X-Gm-Message-State: ACrzQf1sA+3VJ/rQM3svQAUFDNEVIGYvD6EgT9oJjV2lK9PMw9XvHnZl MYVAj09TFNzLQCCZffP/5wxR2Q== X-Google-Smtp-Source: AMsMyM6i9nGclGqwXSChn6aRFvVz56lfZwjmMx8S3ni3ya+yn0nBh4V2pFfHRqUPiG6scf8AhHccmA== X-Received: by 2002:a63:4c05:0:b0:46f:3dfb:98a1 with SMTP id z5-20020a634c05000000b0046f3dfb98a1mr4577492pga.30.1666796693548; Wed, 26 Oct 2022 08:04:53 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id p5-20020a170902e74500b0018658badef3sm3029872plf.232.2022.10.26.08.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 08:04:53 -0700 (PDT) Date: Wed, 26 Oct 2022 15:04:49 +0000 From: Sean Christopherson To: "Wang, Wei W" Cc: Vipin Sharma , "pbonzini@redhat.com" , "dmatlack@google.com" , "andrew.jones@linux.dev" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 2/5] KVM: selftests: Put command line options in alphabetical order in dirty_log_perf_test Message-ID: References: <20221021211816.1525201-1-vipinsh@google.com> <20221021211816.1525201-3-vipinsh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2022, Wang, Wei W wrote: > On Saturday, October 22, 2022 5:18 AM, Vipin Sharma wrote: > > There are 13 command line options and they are not in any order. Put them in > > alphabetical order to make it easy to add new options. > > > > No functional change intended. > > > > Signed-off-by: Vipin Sharma > > --- > > .../selftests/kvm/dirty_log_perf_test.c | 36 ++++++++++--------- > > 1 file changed, 19 insertions(+), 17 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c > > b/tools/testing/selftests/kvm/dirty_log_perf_test.c > > index 56e08da3a87f..5bb6954b2358 100644 > > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > > @@ -406,50 +406,52 @@ int main(int argc, char *argv[]) > > > > guest_modes_append_default(); > > > > - while ((opt = getopt(argc, argv, "eghi:p:m:nb:f:v:os:x:")) != -1) { > > + while ((opt = getopt(argc, argv, "b:ef:ghi:m:nop:s:v:x:")) != -1) { > > switch (opt) { > > + case 'b': > > + guest_percpu_mem_size = parse_size(optarg); > > + break; > > "break" wasn't there. > This is kind of a functional change (i.e. bug fixing), and would be better to be > moved to patch 1. Ya, good catch.