From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89934ECAAA1 for ; Thu, 27 Oct 2022 20:38:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236092AbiJ0UiZ (ORCPT ); Thu, 27 Oct 2022 16:38:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233946AbiJ0UiW (ORCPT ); Thu, 27 Oct 2022 16:38:22 -0400 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 2A4549187E for ; Thu, 27 Oct 2022 13:38:20 -0700 (PDT) Received: (qmail 55890 invoked by uid 1000); 27 Oct 2022 16:38:19 -0400 Date: Thu, 27 Oct 2022 16:38:19 -0400 From: Alan Stern To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Greg Kroah-Hartman , Felipe Balbi , Johan Hovold , Mathias Nyman , Kai-Heng Feng , Matthias Kaehlcke , Michael Grzeschik , Bhuvanesh Surachari , Dan Carpenter , linux-usb@vger.kernel.org Subject: Re: [RFC][PATCH v2 20/31] timers: usb: Use del_timer_shutdown() before freeing timer Message-ID: References: <20221027150525.753064657@goodmis.org> <20221027150928.983388020@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027150928.983388020@goodmis.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 27, 2022 at 11:05:45AM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Before a timer is freed, del_timer_shutdown() must be called. Is this supposed to be true for all timers? Because the USB subsystem contains an awful lot more timers than just the two you touched in this patch. Alan Stern > Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ > > Cc: Greg Kroah-Hartman > Cc: Felipe Balbi > Cc: Johan Hovold > Cc: Alan Stern > Cc: Mathias Nyman > Cc: Kai-Heng Feng > Cc: Matthias Kaehlcke > Cc: Michael Grzeschik > Cc: Bhuvanesh Surachari > Cc: Dan Carpenter > Cc: linux-usb@vger.kernel.org > Signed-off-by: Steven Rostedt (Google) > --- > drivers/usb/core/hub.c | 3 +++ > drivers/usb/gadget/udc/m66592-udc.c | 2 +- > drivers/usb/serial/garmin_gps.c | 2 +- > drivers/usb/serial/mos7840.c | 2 +- > 4 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index bbab424b0d55..397f263ab7da 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -1261,6 +1261,9 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type) > > /* Don't do a long sleep inside a workqueue routine */ > if (type == HUB_INIT2) { > + /* Timers must be shutdown before they are re-initialized */ > + if (hub->init_work.work.func) > + del_timer_shutdown(&hub->init_work.timer); > INIT_DELAYED_WORK(&hub->init_work, hub_init_func3); > queue_delayed_work(system_power_efficient_wq, > &hub->init_work, > diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c > index 931e6362a13d..a6e2f8358adf 100644 > --- a/drivers/usb/gadget/udc/m66592-udc.c > +++ b/drivers/usb/gadget/udc/m66592-udc.c > @@ -1519,7 +1519,7 @@ static int m66592_remove(struct platform_device *pdev) > > usb_del_gadget_udc(&m66592->gadget); > > - del_timer_sync(&m66592->timer); > + del_timer_shutdown(&m66592->timer); > iounmap(m66592->reg); > free_irq(platform_get_irq(pdev, 0), m66592); > m66592_free_request(&m66592->ep[0].ep, m66592->ep0_req);