From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5524CC4332F for ; Thu, 10 Nov 2022 18:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbiKJSLk (ORCPT ); Thu, 10 Nov 2022 13:11:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230392AbiKJSLi (ORCPT ); Thu, 10 Nov 2022 13:11:38 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFDC5B1E8 for ; Thu, 10 Nov 2022 10:11:36 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso2326471pjc.5 for ; Thu, 10 Nov 2022 10:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=m3KjNTpLOPDuLim619IQREZFftn5V2sNi5JTbC4OhKs=; b=oiArtXo3dsDIZIk12+3d8muTDIH47YeNGsnvYXG3IHNf3+UGklQXlFVrj2rA9KCfbc kblMU93BWPTbOsLR/i4DiGyZ+/hy7AGvr8rcGMqTPDqN9dxI6FJboTjwVxtSSFXN/U4j 43jX0sgZBekwNiI2jpX9NeDOANDZB0+667xv2M48wtoHVBXla5izjgCIiIceniKj4dC/ FniODAkw3LS/XpmlzIE4AgqcfftW3QpOygWiTnH4LQtg72RmnhjCDDM6UxnQn7kYIAX8 IJSvv8IBRSojXcSARkJjZAdox9JQRCJyR6ONcds7X+RvJf02mp2V0Wz4ZHKR8T/v/Ngv Nlsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m3KjNTpLOPDuLim619IQREZFftn5V2sNi5JTbC4OhKs=; b=Lj19c1lqPHUzJQOE+NyC0v8hVyF0lkPf1kv8+BOqUAi1R8T0aJtyGV9J8p/sUVnMGK RGb/IDAPMcYh1qqQye+F5T/nhsPCOZM8gcAV9DEeXNu+3rZ9//7E/GKCiXLYISmLunmb KsO2JAP9gTyUagVYvExBqwRmAxF21Dj8/2OYGYueoPKksx3vzZ4zgOf71hzuDuYMj+jF K5zeFGfBtBeANaPOgL7R45qrvVM+XvnuaJ11c1rcOqZ2IaqhwRpzcAZzcoEy1VZfSJG8 BuEdqlLnECMA6mgj4ygnCaph+FfFt0kqTPu2Qq8k2oWE06cD5afSzqo9wkRc9ZNaV329 3eHA== X-Gm-Message-State: ACrzQf1eqWDUdOLSFHIm+j4egQy0qZ2Fsd9efWsuRy9e7mywI7a+j+em OBk6UweCHnL+QaGy6w0I3Ts= X-Google-Smtp-Source: AMsMyM6Y9+9YPB7sjyEYpZPWYu2r+m9ngLj+jIHtMi7NlH3HJi7ojLT2KGxsWRB76PUTPGabjpRZ2w== X-Received: by 2002:a17:90a:c56:b0:213:d200:e958 with SMTP id u22-20020a17090a0c5600b00213d200e958mr61045470pje.6.1668103896191; Thu, 10 Nov 2022 10:11:36 -0800 (PST) Received: from localhost ([2620:10d:c090:400::5:bd7b]) by smtp.gmail.com with ESMTPSA id y23-20020aa79437000000b0056e5f264969sm10393852pfo.47.2022.11.10.10.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 10:11:35 -0800 (PST) Sender: Tejun Heo Date: Thu, 10 Nov 2022 08:11:34 -1000 From: Tejun Heo To: Greg KH Cc: Chengming Zhou , linux-kernel@vger.kernel.org, syzbot+2fdf66e68f5f882c1074@syzkaller.appspotmail.com Subject: Re: [PATCH] fs/kernfs: Fix lockdep warning in kernfs_active() Message-ID: References: <0000000000002473fd05eca7540a@google.com> <20221109120415.55759-1-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 07:00:52PM +0100, Greg KH wrote: > Shouldn't: > https://lore.kernel.org/r/Y0SwqBsZ9BMmZv6x@slm.duckdns.org fix this > instead? The difference is around whether the id based lookup can see hidden files or not. But yeah, it makes more sense to hide it. Thanks. -- tejun