From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41689C43217 for ; Fri, 11 Nov 2022 13:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbiKKNq7 (ORCPT ); Fri, 11 Nov 2022 08:46:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbiKKNq5 (ORCPT ); Fri, 11 Nov 2022 08:46:57 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16EF86035F; Fri, 11 Nov 2022 05:46:57 -0800 (PST) Received: from zn.tnic (p200300ea9733e727329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e727:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9FC851EC04E2; Fri, 11 Nov 2022 14:46:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1668174415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=KrEH4qo/6CC3bjaiEzLx5dxPl06ko0fCOPMoBt29UnE=; b=p3eKEJAPtwcOWdWOEijDzNuZb+pSGA8OQemzr4o6cRttMfFEeFFgf94LDgOYa23kejX4qe lusYsHIxrsJkyK7izmSjudU5MJuBYShU9EJN30HIoEKaomj3+CvBPDR0frFPv8Z4LbTg2a GeayJ5APLWuNESRqnR2S3dxcUfAS7Ag= Date: Fri, 11 Nov 2022 14:46:55 +0100 From: Borislav Petkov To: Jithu Joseph Cc: hdegoede@redhat.com, markgross@kernel.org, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, gregkh@linuxfoundation.org, ashok.raj@intel.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, ravi.v.shankar@intel.com, thiago.macieira@intel.com, athenas.jimenez.gonzalez@intel.com, sohil.mehta@intel.com Subject: Re: [PATCH v2 05/14] x86/microcode/intel: Use appropriate type in microcode_sanity_check() Message-ID: References: <20221021203413.1220137-1-jithu.joseph@intel.com> <20221107225323.2733518-1-jithu.joseph@intel.com> <20221107225323.2733518-6-jithu.joseph@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221107225323.2733518-6-jithu.joseph@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2022 at 02:53:14PM -0800, Jithu Joseph wrote: > The data type of print_err parameter used by microcode_sanity_check() > is int. In prepration for exporting this function, to be used by Unknown word [prepration] in commit message. Suggestions: ['preparation', 'peroration', 'prep ration', 'prep-ration', 'preparations', 'reparation', 'perspiration', "preparation's", 'proportion'] Please introduce a spellchecker into your patch creation workflow. > the IFS driver, Convert it to a more appropriate bool type for readability. "convert" Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette