From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C2F7FA3740 for ; Tue, 1 Nov 2022 01:11:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbiKABLw (ORCPT ); Mon, 31 Oct 2022 21:11:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbiKABLn (ORCPT ); Mon, 31 Oct 2022 21:11:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 430F05FAE; Mon, 31 Oct 2022 18:11:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D3BFD61519; Tue, 1 Nov 2022 01:11:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EB20C433D6; Tue, 1 Nov 2022 01:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667265101; bh=yIXvwJb3xY9eof4ryN8qSDpnHCfY7dClMt5JLJMnsMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VCUPQMTAHaBlHnm85/lF5KV8VLJkYKxqIVPeLHopIx5yuGsESSH6UTzICmnpwmdOT jsQZkDvjvr1LVxhZ6G5Rv2rLav1iBfT2DMrmCq0bOvqF01P29hwaCgCFFXPFw+N8xo Ag/e4ernwnF5TU2nsD3gZH1RBFDdBch5ouR5a9Ya2GRtzkLgDEmNNqP9h75z5AWeYB NyJqxr1kb13AZ0aAzguNiyWBe98MKjWGvnPhHZFu1HMmCSK1ElQDCbs4YkQtd7z7dN v3POEJ9c2yrC1gKrZei4WA2Zh9PK2TlBb6OG4/VVvKRS1HsIZFlxUb68L6Udyg7YHJ hE3AgrdPB6sDw== Date: Tue, 1 Nov 2022 03:11:36 +0200 From: Jarkko Sakkinen To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , "Rafael J. Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , Shuai Xue , Dave Hansen , linux-acpi@vger.kernel.org Subject: Re: [RFC][PATCH v2 05/31] timers: ACPI: Use del_timer_shutdown() before freeing timer Message-ID: References: <20221027150525.753064657@goodmis.org> <20221027150926.006142977@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027150926.006142977@goodmis.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 27, 2022 at 11:05:30AM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Before a timer is freed, del_timer_shutdown() must be called. > > Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ > > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: James Morse > Cc: Tony Luck > Cc: Borislav Petkov > Cc: Shuai Xue > Cc: Dave Hansen > Cc: Jarkko Sakkinen > Cc: linux-acpi@vger.kernel.org > Signed-off-by: Steven Rostedt (Google) > --- > drivers/acpi/apei/ghes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index 80ad530583c9..916b952b14d0 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -1405,7 +1405,7 @@ static int ghes_remove(struct platform_device *ghes_dev) > ghes->flags |= GHES_EXITING; > switch (generic->notify.type) { > case ACPI_HEST_NOTIFY_POLLED: > - del_timer_sync(&ghes->timer); > + del_timer_shutdown(&ghes->timer); > break; > case ACPI_HEST_NOTIFY_EXTERNAL: > free_irq(ghes->irq, ghes); > -- > 2.35.1 Acked-by: Jarkko Sakkinen BR, Jarkko