From: Greg KH <gregkh@linuxfoundation.org>
To: Gabhyun Kim <kimgaby415@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Remove line breaks to match coding style
Date: Tue, 1 Nov 2022 05:53:52 +0100 [thread overview]
Message-ID: <Y2CmYKLzKTVqKqcP@kroah.com> (raw)
In-Reply-To: <20221101011507.GA3802@ubuntu>
On Tue, Nov 01, 2022 at 10:15:07AM +0900, Gabhyun Kim wrote:
> Remove redundant line breaks between function definitions to correct the coding style
Nit, your changelog text is too wide, please properly wrap your lines at
72 columns.
>
> Signed-off-by: Gabhyun Kim <kimgaby415@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_softmac.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 1a3ca3e57623..78828ecac28a 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -22,7 +22,6 @@
>
> static void rtllib_sta_wakeup(struct rtllib_device *ieee, short nl);
>
> -
> static short rtllib_is_54g(struct rtllib_network *net)
> {
> return (net->rates_ex_len > 0) || (net->rates_len > 4);
> @@ -147,9 +146,7 @@ static void init_mgmt_queue(struct rtllib_device *ieee)
> ieee->mgmt_queue_tail = ieee->mgmt_queue_head = 0;
> }
>
> -
> -u8
> -MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
> +u8 MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
> {
You are doing two different types of things here, please only do one
"logical" type of thing at a time in a patch.
thanks,
greg k-h
prev parent reply other threads:[~2022-11-01 4:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 1:15 [PATCH] staging: rtl8192e: Remove line breaks to match coding style Gabhyun Kim
2022-11-01 4:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2CmYKLzKTVqKqcP@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kimgaby415@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).