From: Lee Jones <lee@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Nathan Chancellor <nathan@kernel.org>,
kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 28/28] mfd: intel-lpss: Remove #ifdef guards for PM related functions
Date: Tue, 1 Nov 2022 10:27:08 +0000 [thread overview]
Message-ID: <Y2D0fLkVSSQzve57@google.com> (raw)
In-Reply-To: <Y5KMKR.O7V1VJVC871X@crapouillou.net>
On Mon, 31 Oct 2022, Paul Cercueil wrote:
>
>
> Le lun. 31 oct. 2022 à 15:43:44 +0000, Lee Jones <lee@kernel.org> a écrit :
> > On Mon, 31 Oct 2022, Paul Cercueil wrote:
> >
> > > Hi,
> > >
> > > Le lun. 31 oct. 2022 à 08:03:25 -0700, Nathan Chancellor
> > > <nathan@kernel.org>
> > > a écrit :
> > > > On Mon, Oct 31, 2022 at 02:59:37PM +0000, Lee Jones wrote:
> > > > > On Sun, 23 Oct 2022, kernel test robot wrote:
> > > > >
> > > > > > Hi Paul,
> > > > > >
> > > > > > I love your patch! Yet something to improve:
> > > > > >
> > > > > > [auto build test ERROR on lee-mfd/for-mfd-next]
> > > > > > [also build test ERROR on linus/master v6.1-rc1
> > > next-20221021]
> > > > > > [If your patch is applied to the wrong git tree, kindly drop
> > > us a
> > > > > note.
> > > > > > And when submitting patch, we suggest to use '--base' as
> > > > > documented in
> > > > > >
> > > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > > > > >
> > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/mfd-Remove-ifdef-guards-for-PM-functions/20221023-175612
> > > > > > base:
> > > > > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
> > > > > for-mfd-next
> > > > > > patch link:
> > > > >
> > > https://lore.kernel.org/r/20221023094852.8035-29-paul%40crapouillou.net
> > > > > > patch subject: [PATCH v3 28/28] mfd: intel-lpss: Remove
> > > #ifdef
> > > > > guards for PM related functions
> > > > > > config: i386-randconfig-a013
> > > > > > compiler: clang version 14.0.6
> > > > > (https://github.com/llvm/llvm-project
> > > > > f28c006a5895fc0e329fe15fead81e37457cb1d1)
> > > > > > reproduce (this is a W=1 build):
> > > > > > wget
> > > > >
> > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> > > > > -O ~/bin/make.cross
> > > > > > chmod +x ~/bin/make.cross
> > > > > > # https://github.com/intel-lab-lkp/linux/commit/873891d1ee1634da028bb74d0e7cfa5d77b2f157
> > > > > > git remote add linux-review
> > > > > https://github.com/intel-lab-lkp/linux
> > > > > > git fetch --no-tags linux-review
> > > > >
> > > Paul-Cercueil/mfd-Remove-ifdef-guards-for-PM-functions/20221023-175612
> > > > > > git checkout 873891d1ee1634da028bb74d0e7cfa5d77b2f157
> > > > > > # save the config file
> > > > > > mkdir build_dir && cp config build_dir/.config
> > > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang
> > > > > make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> > > drivers/mfd/
> > > > > >
> > > > > > If you fix the issue, kindly add following tag where
> > > applicable
> > > > > > | Reported-by: kernel test robot <lkp@intel.com>
> > > > > >
> > > > > > All errors (new ones prefixed by >>):
> > > > > >
> > > > > > >> drivers/mfd/intel-lpss-pci.c:75:8: error: type specifier
> > > > > missing, defaults to 'int' [-Werror,-Wimplicit-int]
> > > > > > static INTEL_LPSS_PM_OPS(intel_lpss_pci_pm_ops);
> > > > > > ~~~~~~ ^
> > > > > > >> drivers/mfd/intel-lpss-pci.c:75:26: error: a parameter
> > > list
> > > > > without types is only allowed in a function definition
> > > > > > static INTEL_LPSS_PM_OPS(intel_lpss_pci_pm_ops);
> > > > > > ^
> > > > > > 2 errors generated.
> > > > >
> > > > > Is this a valid error?
> > > >
> > > > Yes, because this change removes the definition of
> > > INTEL_LPSS_PM_OPS in
> > > > intel-lpss.h.
> > >
> > > The "static INTEL_LPSS_PM_OPS(intel_lpss_pci_pm_ops)" is dead code;
> > > just
> > > removing this line should be enough to make it work.
> > >
> > > I'll V2 when I find some time.
> >
> > Thanks.
> >
> > I'll put this set on hold for v2.
>
> If you think the other patches are OK you can merge them, and I'll just send
> a V2 with this one patch.
Okay, works for me.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-11-01 10:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 9:48 [PATCH v3 00/28] mfd: Remove #ifdef guards for PM functions Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 01/28] mfd: 88pm80x: Remove #ifdef guards for PM related functions Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 02/28] mfd: aat2870: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 03/28] mfd: adp5520: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 04/28] mfd: max8925-i2c: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 05/28] mfd: mt6397-irq: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 06/28] mfd: pcf50633: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 07/28] mfd: rc5t583-irq: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 08/28] mfd: stpmic1: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 09/28] mfd: ucb1x00: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 10/28] mfd: 88pm860x: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 11/28] mfd: mcp-sa11x0: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 12/28] mfd: sec: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 13/28] mfd: sm501: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 14/28] mfd: tc6387xb: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 15/28] mfd: tps6586x: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 16/28] mfd: wm8994: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 17/28] mfd: max77620: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 18/28] mfd: t7l66xb: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 19/28] mfd: arizona: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 20/28] mfd: max14577: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 21/28] mfd: max77686: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 22/28] mfd: motorola-cpcap: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 23/28] mfd: sprd-sc27xx: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 24/28] mfd: stmfx: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 25/28] mfd: stmpe: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 26/28] mfd: tc3589x: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 27/28] mfd: tc6393xb: " Paul Cercueil
2022-10-23 9:48 ` [PATCH v3 28/28] mfd: intel-lpss: " Paul Cercueil
2022-10-23 12:55 ` kernel test robot
2022-10-31 14:59 ` Lee Jones
2022-10-31 15:03 ` Nathan Chancellor
2022-10-31 15:11 ` Paul Cercueil
2022-10-31 15:43 ` Lee Jones
2022-10-31 15:53 ` Paul Cercueil
2022-11-01 10:27 ` Lee Jones [this message]
2022-11-07 9:44 ` [PATCH v3 00/28] mfd: Remove #ifdef guards for PM functions Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2D0fLkVSSQzve57@google.com \
--to=lee@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).