From: Petri Latvala <petri.latvala@intel.com>
To: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
Cc: Isabella Basso <isabbasso@riseup.net>,
twoerner@gmail.com, linux-kselftest@vger.kernel.org,
magalilemes00@gmail.com, maira.canal@usp.br, dlatypov@google.com,
tales.aparecida@gmail.com, brendanhiggins@google.com,
linux-kernel@vger.kernel.org, leandro.ribeiro@collabora.com,
igt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
daniel@ffwll.ch, n@nfraprado.net, davidgow@google.com,
skhan@linuxfoundation.org, andrealmeid@riseup.net,
kunit-dev@googlegroups.com
Subject: Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit
Date: Tue, 1 Nov 2022 15:16:02 +0200 [thread overview]
Message-ID: <Y2EcEnAzkt1Qn341@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20221101135425.3ee12c9c@maurocar-mobl2>
On Tue, Nov 01, 2022 at 01:54:25PM +0100, Mauro Carvalho Chehab wrote:
> On Tue, 20 Sep 2022 11:18:25 +0300
> Petri Latvala <petri.latvala@intel.com> wrote:
>
> > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote:
> > > As the DRM selftests are now using KUnit [1], update IGT tests as well.
> > >
> > > [1] - https://lore.kernel.org/all/20220708203052.236290-1-maira.canal@usp.br/
> > >
> > > Signed-off-by: Isabella Basso <isabbasso@riseup.net>
> > > ---
> > > tests/drm_buddy.c | 7 ++++---
> > > tests/drm_mm.c | 7 ++++---
> > > tests/kms_selftest.c | 12 +++++++++---
> > > 3 files changed, 17 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/tests/drm_buddy.c b/tests/drm_buddy.c
> > > index 06876e0c..74c06dce 100644
> > > --- a/tests/drm_buddy.c
> > > +++ b/tests/drm_buddy.c
> > > @@ -6,9 +6,10 @@
> > > #include "igt.h"
> > > #include "igt_kmod.h"
> > >
> > > -IGT_TEST_DESCRIPTION("Basic sanity check of DRM's buddy allocator (struct drm_buddy)");
> > > +IGT_TEST_DESCRIPTION("Basic sanity check of DRM's buddy allocator (struct \
> > > + drm_buddy) using KUnit");
> > >
> > > -igt_main
> > > +igt_simple_main
> > > {
> > > - igt_kselftests("test-drm_buddy", NULL, NULL, NULL);
> > > + igt_kunit("drm_buddy_test", NULL);
> > > }
> >
> > With kselftests we had the ability to only run a specified set of
> > tests, and with or without selection, we had sub-results for each
> > through dynamic subtests. Does kunit have that possibility? I mean I
> > know kunit itself does but what about igt_kunit()?
>
> I don't think so. I created a KUnit with the mock selftests:
>
> $ modinfo test-i915-mock
> filename: /lib/modules/6.1.0-rc2-drm-b1cab854a639+/kernel/drivers/gpu/drm/i915/test-i915-mock.ko
> import_ns: I915_SELFTEST
> license: GPL v2
> depends: i915
> retpoline: Y
> intree: Y
> name: test_i915_mock
> vermagic: 6.1.0-rc2-drm-b1cab854a639+ SMP preempt mod_unload
>
> There's no module parameters. Just loading it makes all tests
> there to run.
Ah, the selection is in kunit.ko itself. kunit.filter_glob, set from
kunit.py with
positional arguments:
filter_glob Filter which KUnit test suites/tests run at boot-time, e.g. list* or list*.*del_test
--
Petri Latvala
next prev parent reply other threads:[~2022-11-01 13:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 0:09 [PATCH i-g-t v2 0/4] Add support for KUnit tests Isabella Basso
2022-08-29 0:09 ` [PATCH i-g-t v2 1/4] lib/igt_kmod: rename kselftest functions to ktest Isabella Basso
2022-09-09 15:05 ` [igt-dev] " Janusz Krzysztofik
2022-08-29 0:09 ` [PATCH i-g-t v2 2/4] lib/igt_kmod.c: check if module is builtin before attempting to unload it Isabella Basso
2022-09-09 15:10 ` [igt-dev] " Janusz Krzysztofik
2022-08-29 0:09 ` [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit Isabella Basso
2022-09-01 6:37 ` David Gow
2022-09-19 20:43 ` Isabella Basso
2022-09-20 0:25 ` Daniel Latypov
2022-11-01 12:43 ` [igt-dev] " Mauro Carvalho Chehab
2022-11-01 12:33 ` Mauro Carvalho Chehab
2022-11-01 17:17 ` Isabella Basso
2022-11-01 18:03 ` Mauro Carvalho Chehab
2022-11-01 12:29 ` Mauro Carvalho Chehab
2022-09-09 15:18 ` Janusz Krzysztofik
2022-09-19 20:55 ` Isabella Basso
2023-02-10 14:56 ` Janusz Krzysztofik
2023-02-10 16:55 ` Isabella Basso
2023-02-14 9:50 ` Janusz Krzysztofik
2022-11-03 9:48 ` Mauro Carvalho Chehab
2022-11-03 11:40 ` Mauro Carvalho Chehab
2022-11-03 12:35 ` Petri Latvala
2022-11-03 14:57 ` Mauro Carvalho Chehab
2022-08-29 0:09 ` [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit Isabella Basso
2022-09-20 8:18 ` [igt-dev] " Petri Latvala
2022-11-01 12:54 ` Mauro Carvalho Chehab
2022-11-01 13:16 ` Petri Latvala [this message]
2022-11-01 13:53 ` Mauro Carvalho Chehab
2022-11-01 14:04 ` Daniel Latypov
2022-09-09 14:49 ` [igt-dev] [PATCH i-g-t v2 0/4] Add support for KUnit tests Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2EcEnAzkt1Qn341@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=andrealmeid@riseup.net \
--cc=brendanhiggins@google.com \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=isabbasso@riseup.net \
--cc=kunit-dev@googlegroups.com \
--cc=leandro.ribeiro@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=magalilemes00@gmail.com \
--cc=maira.canal@usp.br \
--cc=mauro.chehab@linux.intel.com \
--cc=n@nfraprado.net \
--cc=skhan@linuxfoundation.org \
--cc=tales.aparecida@gmail.com \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).