From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E77C4332F for ; Wed, 2 Nov 2022 07:18:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbiKBHSP (ORCPT ); Wed, 2 Nov 2022 03:18:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbiKBHSL (ORCPT ); Wed, 2 Nov 2022 03:18:11 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0522A23151 for ; Wed, 2 Nov 2022 00:18:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 622E6CE1F62 for ; Wed, 2 Nov 2022 07:18:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E85B7C433C1; Wed, 2 Nov 2022 07:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667373487; bh=SfRKT+s1U0JAWcutw2ffQATmHJsVUpEc24ue7Xu2sRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rPMzo/IuIvACXMYS/WFe3l7Zk2VDNHDIChNhJWcedKWRf2ALoZL8lvrAS+ka4faOj 5LYj819PpZmkhfdXdxkenOzUK3GO0BIVAhQgybhcbfZTxl7ebNKMghPg3cdXgxXb4g rnGg4bEqnAIugupYLox8NzMnShGQDXOVydqgDPNc= Date: Wed, 2 Nov 2022 08:19:00 +0100 From: Greg KH To: Philipp Hortmann Cc: Tanjuate Brunostar , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH v3 0/2] staging: vt6655: some checkpatch fixes in the file rxtx.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 11:15:37PM +0100, Philipp Hortmann wrote: > On 11/1/22 19:17, Tanjuate Brunostar wrote: > > These fixes are focused on the function s_vFillRTSHead > > > > v3: changed the function name from fill_rts_head to fill_rts_header as > > head is conventionally used in lists > > > > v2: changed confusing changelog messages > > > > Tanjuate Brunostar (2): > > staging: vt6655: change the function name s_vFillRTSHead > > staging: vt6655: Join some lines of code to avoid code lines ending in > > ( > > > > drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++------------------- > > 1 file changed, 22 insertions(+), 26 deletions(-) > > > > Patch failed at 0001 staging: vt6655: change the function name > s_vFillRTSHead > > > WARNING: line length of 138 exceeds 100 columns > #58: FILE: drivers/staging/vt6655/rxtx.c:915: > + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, > bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > WARNING: line length of 138 exceeds 100 columns > #67: FILE: drivers/staging/vt6655/rxtx.c:934: > + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, > bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > WARNING: line length of 138 exceeds 100 columns > #76: FILE: drivers/staging/vt6655/rxtx.c:948: > + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, > bDisCRC, psEthHeader, wCurrentRate, byFBOption); > > May be you need to consider to break this lines. Not in this commit, just stick to doing one thing per patch. This line is already "too long" so it is not a new problem being introduced with this change. It is fine as-is. thanks, greg k-h