From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB087C4332F for ; Wed, 2 Nov 2022 07:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbiKBHuu (ORCPT ); Wed, 2 Nov 2022 03:50:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230463AbiKBHuW (ORCPT ); Wed, 2 Nov 2022 03:50:22 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B742C27DFA for ; Wed, 2 Nov 2022 00:49:38 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4C4D322B26; Wed, 2 Nov 2022 07:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667375377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mA1wIkmYOej/UB8MIjoht/ySvMPSdMJKGDRaYcOsbG0=; b=SwwhwP+GayFi6VhdsrT8m4Po5s9nz5HUjtkMCkGPHe4tF5iIUVab/dXz3ZZD6fEpE1GX7u Xbffz7wJ1EgH1uhbkZiYdSYmukeQuwXFA4utZEz+VusJBZEQA/rg8/ANvPzrq6qPe2QxTH 8CZNigvslRGhXOolnIm7DaX0b6ifR7k= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2F1E31376E; Wed, 2 Nov 2022 07:49:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6qyhCBEhYmOzcwAAMHmgww (envelope-from ); Wed, 02 Nov 2022 07:49:37 +0000 Date: Wed, 2 Nov 2022 08:49:36 +0100 From: Michal Hocko To: Zach O'Keefe Cc: Yang Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: don't warn if the node is offlined Message-ID: References: <20221031183122.470962-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 02-11-22 08:39:25, Michal Hocko wrote: > On Tue 01-11-22 12:13:35, Zach O'Keefe wrote: > [...] > > This is slightly tangential - but I don't want to send a new mail > > about it -- but I wonder if we should be doing __GFP_THISNODE + > > explicit node vs having hpage_collapse_find_target_node() set a > > nodemask. We could then provide fallback nodes for ties, or if some > > node contained > some threshold number of pages. > > I would simply go with something like this (not even compile tested): Btw. while at it. It is really ugly to allocate 4kB stack space for node mask for !NUMA configurations! If you are touching that area then this shouldn't be hard to fix. -- Michal Hocko SUSE Labs