From: Deepak R Varma <drv@mailo.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] staging: rtl8192u: unused code cleanup
Date: Wed, 2 Nov 2022 16:24:57 +0530 [thread overview]
Message-ID: <Y2JMgdAzOS25qQuA@lion2204> (raw)
In-Reply-To: <Y2Ib7FjwfqbcZ77h@kroah.com>
On Wed, Nov 02, 2022 at 08:27:40AM +0100, Greg KH wrote:
> On Mon, Oct 31, 2022 at 11:25:14PM +0530, Deepak R Varma wrote:
> > Remove unnecessary or unused code.
> >
> > Changes in v2:
> > Patch1:
> > 1. Revise patch log to explain impact of the patch
> > Suggested by gregkh@linuxfoundation.org
> > Patch2:
> > 1. Review other similar macro defines and clean those up as well.
> > Suggested by gregkh@linuxfoundation.org
> > 2. Revise patch log to explain impact of the patch
> > Suggested by julia.lawall@inria.fr
> >
> > Deepak R Varma (2):
> > staging: rtl8192u: remove unnecessary function implementation
> > staging: rtl8192u: remove redundant macro definition
> >
> > .../staging/rtl8192u/ieee80211/ieee80211.h | 67 -------------------
> > .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 --
> > .../rtl8192u/ieee80211/ieee80211_module.c | 3 -
> > 3 files changed, 76 deletions(-)
>
> This series causes a build breakage:
>
> MODPOST Module.symvers
> ../ERROR: modpost: net/mac80211/mac80211: 'ieee80211_wake_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
> ERROR: modpost: net/mac80211/mac80211: 'ieee80211_stop_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
> make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1
> make: *** [Makefile:1944: modpost] Error 2
>
> Always test build your changes.
My apologies. I did a limited driver specific build but did not run a full make.
I understand that the EXPORT_SYMBOL is across the kernel and I should have run a
full build.
I have made the corrections and now running a full build. I will send a revision
shortly.
Sorry for the trouble.
./drv
>
> greg k-h
>
prev parent reply other threads:[~2022-11-02 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 17:55 [PATCH v2 0/2] staging: rtl8192u: unused code cleanup Deepak R Varma
2022-10-31 17:55 ` [PATCH v2 1/2] staging: rtl8192u: remove unnecessary function implementation Deepak R Varma
2022-10-31 17:56 ` [PATCH v2 2/2] staging: rtl8192u: remove redundant macro definition Deepak R Varma
2022-11-02 7:27 ` [PATCH v2 0/2] staging: rtl8192u: unused code cleanup Greg KH
2022-11-02 10:54 ` Deepak R Varma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2JMgdAzOS25qQuA@lion2204 \
--to=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).