From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB87C4332F for ; Wed, 9 Nov 2022 18:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230256AbiKISUn (ORCPT ); Wed, 9 Nov 2022 13:20:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiKISUi (ORCPT ); Wed, 9 Nov 2022 13:20:38 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2F7324F17; Wed, 9 Nov 2022 10:20:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2CCF961C28; Wed, 9 Nov 2022 18:20:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF291C433C1; Wed, 9 Nov 2022 18:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668018036; bh=lHGIXa/gzMZc3tKmxe07xLxCc5ENdiRStUxmf+RJ76E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aDq7gFkVLaBFz3piUo2ROtjM7vxyTK0VgBb5MXkNJgRAbmWlBmTQAiI41f+1Fq2qu hkBF5vneS+6G0CgV0oggBnfm/bAMNfaMfflzjPZ8cCLyMC+11/bbC0LaTWC8z9KShf KEvyGPmr1uvvOjajknE8coL4wgOAepw9wtS7ip9S9Ed8mf7iJ/Z8fkvVZbYim3DyHw /CjzIqaQe8NMx0OCe2GRwOsKL4SZ42DEtNbTPZSJ03z7K5ixHbjnvnlvVElMzKTUAE hQKRXQgFBEbHSRD6K2dYHJ/IssE5VQhMrtpOw/7P2lXAzoDqsuMLK67aCu4bO3UtAn f/7fnsVKFTauA== Date: Wed, 9 Nov 2022 20:20:31 +0200 From: Leon Romanovsky To: Ivan Vecera Cc: netdev@vger.kernel.org, sassmann@redhat.com, Jacob Keller , Patryk Piotrowski , SlawomirX Laba , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "moderated list:INTEL ETHERNET DRIVERS" , open list Subject: Re: [PATCH net] iavf: Do not restart Tx queues after reset task failure Message-ID: References: <20221108102502.2147389-1-ivecera@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221108102502.2147389-1-ivecera@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2022 at 11:25:02AM +0100, Ivan Vecera wrote: > After commit aa626da947e9 ("iavf: Detach device during reset task") > the device is detached during reset task and re-attached at its end. > The problem occurs when reset task fails because Tx queues are > restarted during device re-attach and this leads later to a crash. <...> > + if (netif_running(netdev)) { > + /* Close device to ensure that Tx queues will not be started > + * during netif_device_attach() at the end of the reset task. > + */ > + rtnl_lock(); > + dev_close(netdev); > + rtnl_unlock(); > + } Sorry for my naive question, I see this pattern a lot (including RDMA), so curious. Everyone checks netif_running() outside of rtnl_lock, while dev_close() changes state bit __LINK_STATE_START. Shouldn't rtnl_lock() placed before netif_running()? Thanks > + > dev_err(&adapter->pdev->dev, "failed to allocate resources during reinit\n"); > reset_finish: > rtnl_lock(); > -- > 2.37.4 >