From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A631AC433FE for ; Sun, 13 Nov 2022 22:56:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235422AbiKMW4F (ORCPT ); Sun, 13 Nov 2022 17:56:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235416AbiKMW4B (ORCPT ); Sun, 13 Nov 2022 17:56:01 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE55E10040; Sun, 13 Nov 2022 14:55:57 -0800 (PST) Received: from zn.tnic (p200300ea9733e773329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e773:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4E0691EC02DD; Sun, 13 Nov 2022 23:55:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1668380156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=omkKJP3QRSJ1TQMFymyT/Q913sb0v8rXOPsXoq9txnY=; b=o7voXxnp8sns/BkqtUykHJvs6FoBv16oER5WblDLI0Cja/mXKdsws6uEMTDyF1jEffs7NP on7UlHI08l0QKFaWuuDc7Fwaldm9cjmPH9g2owbwmGF80jnAKUboUXg8QNNVO4JwakpCqJ ItEZFOq+n35qnw3k9CJehTbMUsU7VsI= Date: Sun, 13 Nov 2022 23:55:52 +0100 From: Borislav Petkov To: Tony Luck Cc: "Joseph, Jithu" , "gregkh@linuxfoundation.org" , Thiago Macieira , "hdegoede@redhat.com" , "markgross@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "Raj, Ashok" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "patches@lists.linux.dev" , "Shankar, Ravi V" , "Jimenez Gonzalez, Athenas" , "Mehta, Sohil" Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs entry Message-ID: References: <20221107225323.2733518-13-jithu.joseph@intel.com> <5e65889d-d68c-b29d-6cea-7b4ce4c87b4a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 13, 2022 at 01:33:50PM -0800, Tony Luck wrote: > IMHO option 1 is following the microcode precedent of having the kernel > construct the filename based on the {x86,model,stepping} fields of > struct cpuinfo_x86. You can't follow the microcode precedent if you have more than one file. > I think option 2 isn't really doing the user any favors. Having them > feed all the *.scan files they find in /lib/firmware/intel/ifs_0 to the > driver to see which ones work becomes progressively worse in every CPU > generation. Any script/app running tests is likely to do the ff-mm-ss > filter itself ... so why have the kernel do it too? So you think that feeding a sequence number is more intuitive? I guess I've given all my arguments here but you folks don't see things this way. I guess time will show whether the sequence number thing was a good idea. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette