From: Greg KH <gregkh@linuxfoundation.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Sven van Ashbrook <svenva@chromium.org>,
Rafael J Wysocki <rafael@kernel.org>,
linux-pm@vger.kernel.org, platform-driver-x86@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
John Stultz <jstultz@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
S-k Shyam-sundar <Shyam-sundar.S-k@amd.com>,
rrangel@chromium.org, Rajat Jain <rajatja@google.com>,
David E Box <david.e.box@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v2 1/3] PM: Add a sysfs files to represent sleep duration
Date: Mon, 14 Nov 2022 08:12:42 +0100 [thread overview]
Message-ID: <Y3HqauaLfF6iJTGJ@kroah.com> (raw)
In-Reply-To: <20221110064723.8882-2-mario.limonciello@amd.com>
On Thu, Nov 10, 2022 at 12:47:21AM -0600, Mario Limonciello wrote:
> +static ssize_t last_hw_state_residency_show(struct kobject *kobj,
> + struct kobj_attribute *attr, char *buf)
> +{
> + return sprintf(buf, "%llu\n", suspend_stats.last_hw_state_residency);
sysfs_emit() please for sysfs files, not a "raw" sprintf().
checkpatch.pl should have caught that for you, but sometimes it doesn't.
thanks,
greg k-h
next prev parent reply other threads:[~2022-11-14 7:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 6:47 [RFC v2 0/3] Introduce infrastructure to report time in hardware sleep state Mario Limonciello
2022-11-10 6:47 ` [RFC v2 1/3] PM: Add a sysfs files to represent sleep duration Mario Limonciello
2022-11-13 23:53 ` Thomas Gleixner
2022-11-14 19:12 ` Limonciello, Mario
2022-11-15 10:32 ` Hans de Goede
2022-11-15 14:13 ` Limonciello, Mario
2022-11-17 2:40 ` Box, David E
2022-11-14 7:12 ` Greg KH [this message]
2022-11-15 14:45 ` Rafael J. Wysocki
2022-11-15 15:17 ` Limonciello, Mario
2022-11-15 16:35 ` Rafael J. Wysocki
[not found] ` <CAHQZ30BCXtyJ9qqHHX5eztXbgA_A8yH48+AQVMCB64CXjqE+hQ@mail.gmail.com>
2022-11-15 17:26 ` Limonciello, Mario
2022-11-15 17:52 ` Rafael J. Wysocki
2022-11-15 17:58 ` Limonciello, Mario
2022-11-15 19:08 ` Rafael J. Wysocki
2022-11-10 6:47 ` [RFC v2 2/3] platform/x86/amd: pmc: Report duration of time in deepest hw state Mario Limonciello
2022-11-10 6:47 ` [RFC v2 3/3] platform/x86/intel/pmc: core: Report duration of time in HW sleep state Mario Limonciello
2022-11-13 23:57 ` Thomas Gleixner
2022-11-14 19:06 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3HqauaLfF6iJTGJ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=david.e.box@intel.com \
--cc=hdegoede@redhat.com \
--cc=irenic.rajneesh@gmail.com \
--cc=jstultz@google.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rajatja@google.com \
--cc=rrangel@chromium.org \
--cc=sboyd@kernel.org \
--cc=svenva@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).