From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Barry Song <baohua@kernel.org>, Ben Segall <bsegall@google.com>,
haniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Gal Pressman <gal@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Carstens <hca@linux.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Juri Lelli <juri.lelli@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Saeed Mahameed <saeedm@nvidia.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tariq Toukan <tariqt@nvidia.com>,
Tariq Toukan <ttoukan.linux@gmail.com>,
Tony Luck <tony.luck@intel.com>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 3/4] sched: add sched_numa_find_nth_cpu()
Date: Mon, 14 Nov 2022 16:32:09 +0200 [thread overview]
Message-ID: <Y3JRaSRpDJDUn2br@smile.fi.intel.com> (raw)
In-Reply-To: <20221112190946.728270-4-yury.norov@gmail.com>
On Sat, Nov 12, 2022 at 11:09:45AM -0800, Yury Norov wrote:
> The function finds Nth set CPU in a given cpumask starting from a given
> node.
>
> Leveraging the fact that each hop in sched_domains_numa_masks includes the
> same or greater number of CPUs than the previous one, we can use binary
> search on hops instead of linear walk, which makes the overall complexity
> of O(log n) in terms of number of cpumask_weight() calls.
...
> +struct __cmp_key {
> + const struct cpumask *cpus;
> + struct cpumask ***masks;
> + int node;
> + int cpu;
> + int w;
> +};
> +
> +static int cmp(const void *a, const void *b)
Calling them key and pivot (as in the caller), would make more sense.
> +{
What about
const (?) struct cpumask ***masks = (...)pivot;
> + struct cpumask **prev_hop = *((struct cpumask ***)b - 1);
= masks[-1];
> + struct cpumask **cur_hop = *(struct cpumask ***)b;
= masks[0];
?
> + struct __cmp_key *k = (struct __cmp_key *)a;
> + if (cpumask_weight_and(k->cpus, cur_hop[k->node]) <= k->cpu)
> + return 1;
> + k->w = (b == k->masks) ? 0 : cpumask_weight_and(k->cpus, prev_hop[k->node]);
> + if (k->w <= k->cpu)
> + return 0;
Can k->cpu be negative? If no, we can rewrite above as
k->w = 0;
if (b == k->masks)
return 0;
k->w = cpumask_weight_and(k->cpus, prev_hop[k->node]);
> + return -1;
> +}
...
> +int sched_numa_find_nth_cpu(const struct cpumask *cpus, int cpu, int node)
> +{
> + struct __cmp_key k = { cpus, NULL, node, cpu, 0 };
You can drop NULL and 0 while using C99 assignments.
> + int hop, ret = nr_cpu_ids;
> + rcu_read_lock();
+ Blank line?
> + k.masks = rcu_dereference(sched_domains_numa_masks);
> + if (!k.masks)
> + goto unlock;
> + hop = (struct cpumask ***)
> + bsearch(&k, k.masks, sched_domains_numa_levels, sizeof(k.masks[0]), cmp) - k.masks;
Strange indentation. I would rather see the split on parameters and
maybe '-' operator.
sizeof(*k.masks) is a bit shorter, right?
Also we may go with
struct cpumask ***masks;
struct __cmp_key k = { .cpus = cpus, .node = node, .cpu = cpu };
> + ret = hop ?
> + cpumask_nth_and_andnot(cpu - k.w, cpus, k.masks[hop][node], k.masks[hop-1][node]) :
> + cpumask_nth_and(cpu - k.w, cpus, k.masks[0][node]);
> +unlock:
out_unlock: shows the intention more clearly, no?
> + rcu_read_unlock();
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-14 14:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 19:09 [PATCH v2 0/4] cpumask: improve on cpumask_local_spread() locality Yury Norov
2022-11-12 19:09 ` [PATCH v2 1/4] lib/find: introduce find_nth_and_andnot_bit Yury Norov
2022-11-12 19:09 ` [PATCH v2 2/4] cpumask: introduce cpumask_nth_and_andnot Yury Norov
2022-11-12 19:09 ` [PATCH v2 3/4] sched: add sched_numa_find_nth_cpu() Yury Norov
2022-11-14 14:32 ` Andy Shevchenko [this message]
2022-11-14 15:02 ` Andy Shevchenko
2022-12-08 2:55 ` Yury Norov
2022-11-15 17:25 ` Valentin Schneider
2022-11-12 19:09 ` [PATCH v2 4/4] cpumask: improve on cpumask_local_spread() locality Yury Norov
2022-11-15 17:24 ` [PATCH v2 0/4] " Valentin Schneider
2022-11-15 18:32 ` Yury Norov
2022-11-17 12:23 ` Valentin Schneider
2022-11-28 6:39 ` Tariq Toukan
2022-11-30 1:47 ` Yury Norov
2022-12-07 12:53 ` Tariq Toukan
2022-12-07 20:45 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3JRaSRpDJDUn2br@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=baohua@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=davem@davemloft.net \
--cc=dietmar.eggemann@arm.com \
--cc=gal@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgg@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=tony.luck@intel.com \
--cc=ttoukan.linux@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).