From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94B11C433FE for ; Sat, 19 Nov 2022 16:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234432AbiKSQ7s (ORCPT ); Sat, 19 Nov 2022 11:59:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbiKSQ7l (ORCPT ); Sat, 19 Nov 2022 11:59:41 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB7CC11469; Sat, 19 Nov 2022 08:59:37 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 82AE1749; Sat, 19 Nov 2022 17:59:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668877175; bh=5XR3sCqqEd6GXsl5hg+C3PS+jEEDwIW3YkQxbvVxj2Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UCmxTBRSYdoReX60CGoNzW4ohn53YH+q8JSuG6FI5bWL3JB6AP+yYOAm6VcSlPEmH VAtYy1JjCd/mfEdmIJO68PWEegiqp76oygvo1r4WPK1Sm/5siJ+6eKrmh7YDIJJZVM 6hJ2earUZcyvIcy7IhVMCKC46nyx7QeGY1nngMZc= Date: Sat, 19 Nov 2022 18:59:19 +0200 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Paul Elder , linux-media@vger.kernel.org, Dafna Hirschfeld , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Helen Koike , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example Message-ID: References: <20221118093931.1284465-1-paul.elder@ideasonboard.com> <20221118093931.1284465-3-paul.elder@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Fri, Nov 18, 2022 at 02:06:14PM +0100, Krzysztof Kozlowski wrote: > On 18/11/2022 10:39, Paul Elder wrote: > > From: Laurent Pinchart > > > > Add an example to the rockchip-isp1 DT binding that showcases usage of > > the parallel input of the ISP, connected to the CSI-2 receiver internal > > to the i.MX8MP. > > > > Signed-off-by: Laurent Pinchart > > Missing SoB. > > > --- > > .../bindings/media/rockchip-isp1.yaml | 72 +++++++++++++++++++ > > 1 file changed, 72 insertions(+) > > > > I don't know what do you demonstrate there... usage of endpoints? That's > the only difference. Such usage is the same everywhere, nothing specific > to this example. You already have two examples, so I don't think this > brings anything more. The i.MX8MP is the only SoC integrating this ISP (and supported in mainlineà that has an external CSI-2 receiver, as opposed to using the CSI-2 receiver from the ISP. This patch this showcases the DT integration for that use case. If you think it's not worth it, I'm fine dropping it. -- Regards, Laurent Pinchart