From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58CD4C433FE for ; Sat, 19 Nov 2022 17:30:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234354AbiKSRam (ORCPT ); Sat, 19 Nov 2022 12:30:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234320AbiKSRai (ORCPT ); Sat, 19 Nov 2022 12:30:38 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 071A61179; Sat, 19 Nov 2022 09:30:37 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E938749; Sat, 19 Nov 2022 18:30:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879035; bh=o9lUHRbGBJ0hhJHW6kYdWTu2wvJ8H+zsns7IATdHrbM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rrEiHpwKhllKXjddcBxHOnbfouXahjh8kHM9Y+KBoChKcIJIGdcds5ltGgJsT70xQ ngASIOg81jJgPbfCgGtqvD3+AJfW1RWt+B4EFPM4Ps0sJ41bqhG/knvEoyBAxX1ron um213vJD5vIKI8cw2LXfb9pBRSe7Sdj4BRr7FJwQ= Date: Sat, 19 Nov 2022 19:30:19 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 031/606] drm/bridge: sii8620: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-32-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-32-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 11:36:05PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/sil-sii8620.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c > index 511982a1cedb..b96d03cd878d 100644 > --- a/drivers/gpu/drm/bridge/sil-sii8620.c > +++ b/drivers/gpu/drm/bridge/sil-sii8620.c > @@ -2284,8 +2284,7 @@ static const struct drm_bridge_funcs sii8620_bridge_funcs = { > .mode_valid = sii8620_mode_valid, > }; > > -static int sii8620_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int sii8620_probe(struct i2c_client *client) > { > struct device *dev = &client->dev; > struct sii8620 *ctx; > @@ -2379,7 +2378,7 @@ static struct i2c_driver sii8620_driver = { > .name = "sii8620", > .of_match_table = of_match_ptr(sii8620_dt_match), > }, > - .probe = sii8620_probe, > + .probe_new = sii8620_probe, > .remove = sii8620_remove, > .id_table = sii8620_id, > }; > -- > 2.38.1 > -- Regards, Laurent Pinchart