linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Wang Yufen <wangyufen@huawei.com>
Cc: bvanassche@acm.org, jgg@ziepe.ca,
	dennis.dalessandro@cornelisnetworks.com,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	andriy.shevchenko@linux.intel.com, bart.vanassche@wdc.com,
	easwar.hariharan@intel.com
Subject: Re: [PATCH v3 2/2] RDMA/srp: Fix error return code in srp_parse_options()
Date: Mon, 28 Nov 2022 13:58:34 +0200	[thread overview]
Message-ID: <Y4SiaoUl1PMWDMcG@unreal> (raw)
In-Reply-To: <1669470654-45828-2-git-send-email-wangyufen@huawei.com>

On Sat, Nov 26, 2022 at 09:50:54PM +0800, Wang Yufen wrote:
> In the previous while loop, "ret" may be assigned zero, , so the error
> return code may be incorrectly set to 0 instead of -EINVAL.
> Add out_with_einval goto label and covert all "goto out;" to "goto
> out_with_einval:" where it's appropriate, alse investigate each case
> separately as Andy suggessted.
> 
> Fixes: e711f968c49c ("IB/srp: replace custom implementation of hex2bin()")
> Fixes: 2a174df0c602 ("IB/srp: Use kstrtoull() instead of simple_strtoull()")
> Fixes: 19f313438c77 ("IB/srp: Add RDMA/CM support")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
>  drivers/infiniband/ulp/srp/ib_srp.c | 86 ++++++++++++++++++++++++++-----------
>  1 file changed, 60 insertions(+), 26 deletions(-)

<...>

> @@ -3623,6 +3653,10 @@ static int srp_parse_options(struct net *net, const char *buf,
>  out:
>  	kfree(options);
>  	return ret;
> +
> +out_with_einval:

It needs to be changed back.

Thanks

> +	ret = -EINVAL;
> +	goto out;
>  }
>  
>  static ssize_t add_target_store(struct device *dev,
> -- 
> 1.8.3.1
> 

  reply	other threads:[~2022-11-28 11:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-26 13:50 [PATCH v3 1/2] RDMA/hfi1: Fix error return code in parse_platform_config() Wang Yufen
2022-11-26 13:50 ` [PATCH v3 2/2] RDMA/srp: Fix error return code in srp_parse_options() Wang Yufen
2022-11-28 11:58   ` Leon Romanovsky [this message]
2022-11-28 11:57 ` [PATCH v3 1/2] RDMA/hfi1: Fix error return code in parse_platform_config() Leon Romanovsky
2022-11-29  1:30   ` wangyufen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4SiaoUl1PMWDMcG@unreal \
    --to=leon@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bart.vanassche@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=easwar.hariharan@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=wangyufen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).