From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B79C43217 for ; Thu, 1 Dec 2022 17:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbiLARft (ORCPT ); Thu, 1 Dec 2022 12:35:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbiLARfq (ORCPT ); Thu, 1 Dec 2022 12:35:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3594792A0F; Thu, 1 Dec 2022 09:35:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DDA5EB81FC0; Thu, 1 Dec 2022 17:35:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C493C433D6; Thu, 1 Dec 2022 17:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669916143; bh=N41KtYO2yiNFGuVtHGyIzgY5vlpL+NViLtcBnbs2M+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P0Is98dJX/lEgrNKidWd4r3R/aj903gZv/tXDECOvOQ/Ds9yKmdrWjovT+No78TD+ 1PW+hXNH/unwb/zQOZLQ69XKTJ5z7n15ji1SiaFT0jdBWPrEf5+0rCDyWKF++/Bym3 44jDukzrqEsw2FCSw0r1N26vzQh9cfMQ8tuEG0bAvkkNiJMR6siOcOSyRLNvB+yGFe E58qh8XwHnv2eAZRslaPjzfYyHhTz+NSrJ5bDEOg1ZXutsfpWNbP4oU4dDJQgScVli AkvVNHZ+aGf+mPFBmaY7MTc1FWMmBLyHKue5SEq5/s6dAIymImJ0ZZkHCCMa4BBcc0 nIOPBZXf/HENQ== Date: Thu, 1 Dec 2022 17:35:37 +0000 From: Conor Dooley To: Krzysztof Kozlowski Cc: Yanhong Wang , linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis Subject: Re: [PATCH v1 3/7] dt-bindings: net: Add bindings for StarFive dwmac Message-ID: References: <20221201090242.2381-1-yanhong.wang@starfivetech.com> <20221201090242.2381-4-yanhong.wang@starfivetech.com> <36565cc1-3c48-0fa8-f98b-414a7ac8f5bf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36565cc1-3c48-0fa8-f98b-414a7ac8f5bf@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 01, 2022 at 05:21:04PM +0100, Krzysztof Kozlowski wrote: > On 01/12/2022 10:02, Yanhong Wang wrote: > > Add bindings for the StarFive dwmac module on the StarFive RISC-V SoCs. > > Subject: drop second, redundant "bindings". > > > > > Signed-off-by: Yanhong Wang > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > +properties: > > + compatible: > > + oneOf: > > Drop oneOf. You do not have more cases here. > > > + - items: > > + - enum: > > + - starfive,dwmac > > Wrong indentation.... kind of expected since you did not test the bindings. > > > + - const: snps,dwmac-5.20 Disclaimer: no familiarity with the version info with DW stuff Is it a bit foolish to call this binding "starfive,dwmac"? Could there not be another StarFive SoC in the future that uses another DW mac IP version & this would be better off as "starfive,jh7110-dwmac" or similar? Thanks, Conor.