From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: James Clark <james.clark@arm.com>,
linux-perf-users@vger.kernel.org, sandipan.das@amd.com,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf: Fix interpretation of branch records
Date: Fri, 2 Dec 2022 15:33:55 -0300 [thread overview]
Message-ID: <Y4pFE1bNObTTLL2+@kernel.org> (raw)
In-Reply-To: <8b7606a4-63e4-6d0c-6b83-5ef51c83385c@arm.com>
Em Thu, Dec 01, 2022 at 09:46:53AM +0530, Anshuman Khandual escreveu:
>
>
> On 11/30/22 22:21, James Clark wrote:
> > Commit 93315e46b000 ("perf/core: Add speculation info to branch
> > entries") added a new field in between type and new_type. Perf has
> > its own copy of this struct so update it to match the kernel side.
> >
> > This doesn't currently cause any issues because new_type is only used
> > by the Arm BRBE driver which isn't merged yet.
> >
> > Fixes: 93315e46b000 ("perf/core: Add speculation info to branch entries")
> > Signed-off-by: James Clark <james.clark@arm.com>
>
> Again, problem from having the same structure in two different places
Indeed, this was my first reaction, how about backward compatibility, is
this really an ABI?
- Arnaldo
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> > ---
> > tools/perf/util/branch.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/branch.h b/tools/perf/util/branch.h
> > index d6017c9b1872..3ed792db1125 100644
> > --- a/tools/perf/util/branch.h
> > +++ b/tools/perf/util/branch.h
> > @@ -22,9 +22,10 @@ struct branch_flags {
> > u64 abort:1;
> > u64 cycles:16;
> > u64 type:4;
> > + u64 spec:2;
> > u64 new_type:4;
> > u64 priv:3;
> > - u64 reserved:33;
> > + u64 reserved:31;
> > };
> > };
> > };
--
- Arnaldo
next prev parent reply other threads:[~2022-12-02 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 16:51 [PATCH] perf: Fix interpretation of branch records James Clark
2022-11-30 18:35 ` Namhyung Kim
2022-12-01 4:16 ` Anshuman Khandual
2022-12-02 18:33 ` Arnaldo Carvalho de Melo [this message]
2022-12-01 9:02 ` Sandipan Das
2022-12-01 10:17 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4pFE1bNObTTLL2+@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).