* [PATCH] ASoC: rockchip: spdif: Add missing clk_disable_unprepare() in rockchip_pdm_runtime_resume()
@ 2022-12-05 2:43 Wang Jingjin
2022-12-07 13:58 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Wang Jingjin @ 2022-12-05 2:43 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, heiko, sugar.zhang, alsa-devel,
linux-arm-kernel, linux-rockchip, linux-kernel
Cc: wangjingjin1
The clk_disable_unprepare() should be called in the error handling of
rockchip_pdm_runtime_resume().
Fixes: fc05a5b22253 ("ASoC: rockchip: add support for pdm controller")
Signed-off-by: Wang Jingjin <wangjingjin1@huawei.com>
---
sound/soc/rockchip/rockchip_pdm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c
index a7549f827235..5b1e47bdc376 100644
--- a/sound/soc/rockchip/rockchip_pdm.c
+++ b/sound/soc/rockchip/rockchip_pdm.c
@@ -431,6 +431,7 @@ static int rockchip_pdm_runtime_resume(struct device *dev)
ret = clk_prepare_enable(pdm->hclk);
if (ret) {
+ clk_disable_unprepare(pdm->clk);
dev_err(pdm->dev, "hclock enable failed %d\n", ret);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: rockchip: spdif: Add missing clk_disable_unprepare() in rockchip_pdm_runtime_resume()
2022-12-05 2:43 [PATCH] ASoC: rockchip: spdif: Add missing clk_disable_unprepare() in rockchip_pdm_runtime_resume() Wang Jingjin
@ 2022-12-07 13:58 ` Mark Brown
2022-12-08 6:10 ` Wangjingjin(KERNEL)
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2022-12-07 13:58 UTC (permalink / raw)
To: Wang Jingjin
Cc: lgirdwood, perex, tiwai, heiko, sugar.zhang, alsa-devel,
linux-arm-kernel, linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
On Mon, Dec 05, 2022 at 10:43:17AM +0800, Wang Jingjin wrote:
> The clk_disable_unprepare() should be called in the error handling of
> rockchip_pdm_runtime_resume().
>
> Fixes: fc05a5b22253 ("ASoC: rockchip: add support for pdm controller")
> Signed-off-by: Wang Jingjin <wangjingjin1@huawei.com>
> ---
> sound/soc/rockchip/rockchip_pdm.c | 1 +
> 1 file changed, 1 insertion(+)
The subject line says this is a fix for the S/PDIF driver but the patch
is for the PDM driver and I see you sent a separate fix for the PDM
driver.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: rockchip: spdif: Add missing clk_disable_unprepare() in rockchip_pdm_runtime_resume()
2022-12-07 13:58 ` Mark Brown
@ 2022-12-08 6:10 ` Wangjingjin(KERNEL)
0 siblings, 0 replies; 3+ messages in thread
From: Wangjingjin(KERNEL) @ 2022-12-08 6:10 UTC (permalink / raw)
To: Mark Brown
Cc: lgirdwood, perex, tiwai, heiko, sugar.zhang, alsa-devel,
linux-arm-kernel, linux-rockchip, linux-kernel
Right，will fix in v2
Thanks for review.
在 2022/12/7 21:58, Mark Brown 写道:
> On Mon, Dec 05, 2022 at 10:43:17AM +0800, Wang Jingjin wrote:
>> The clk_disable_unprepare() should be called in the error handling of
>> rockchip_pdm_runtime_resume().
>>
>> Fixes: fc05a5b22253 ("ASoC: rockchip: add support for pdm controller")
>> Signed-off-by: Wang Jingjin <wangjingjin1@huawei.com>
>> ---
>> sound/soc/rockchip/rockchip_pdm.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> The subject line says this is a fix for the S/PDIF driver but the patch
> is for the PDM driver and I see you sent a separate fix for the PDM
> driver.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-08 6:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-05 2:43 [PATCH] ASoC: rockchip: spdif: Add missing clk_disable_unprepare() in rockchip_pdm_runtime_resume() Wang Jingjin
2022-12-07 13:58 ` Mark Brown
2022-12-08 6:10 ` Wangjingjin(KERNEL)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).