From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81934C63708 for ; Thu, 8 Dec 2022 15:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229793AbiLHP6r (ORCPT ); Thu, 8 Dec 2022 10:58:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229752AbiLHP6p (ORCPT ); Thu, 8 Dec 2022 10:58:45 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EF045E9FD; Thu, 8 Dec 2022 07:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670515125; x=1702051125; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fomqMkSXsLbKd6rtLl8ELmzFBExU8tpiHRDpuopuVvY=; b=Dvlb29fjmz/uqIpSKaVuGpcZa39wOSpJY0dtN9QuaOIJfuWfljUh1ROE BnXsIiVkPNQ2ywmchDCuExRWnn6YoGy6YaxngqPuUAlhL3htcbZ3BAQqs RNdZui2Q28Xy4QT4yGY9eGn47X/unpyfByRrdBdLlbqofeAv4q+GTAGAa GF+89LLUb3aFvEPpt5Cfko/gMsWKyD66qZgk+Crx5WzCNGtMe0+4Pkg78 8j+E/N9ECllIXcktsE9M6GIzhcbNksupcFdFKZo5A8cA13kcId5WDsoLZ weYV5DoDi+gLsBZjaBazfTpaAC2hLyKDiOUAyuzHUv4/DxVGGoDDSeAah A==; X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="379389767" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="379389767" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 07:57:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="975918507" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="975918507" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 08 Dec 2022 07:57:27 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p3JH1-006Qep-2m; Thu, 08 Dec 2022 17:57:23 +0200 Date: Thu, 8 Dec 2022 17:57:23 +0200 From: Andy Shevchenko To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Wolfram Sang , Luca Ceresoli , Matti Vaittinen , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Sakari Ailus , Laurent Pinchart , Michael Tretter , Shawn Tu , Hans Verkuil , Mike Pagano , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut Subject: Re: [PATCH v5 0/8] i2c-atr and FPDLink Message-ID: References: <20221208104006.316606-1-tomi.valkeinen@ideasonboard.com> <0340d15c-be0a-cd28-4149-7976896f8eb1@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0340d15c-be0a-cd28-4149-7976896f8eb1@ideasonboard.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 08, 2022 at 04:40:58PM +0200, Tomi Valkeinen wrote: > On 08/12/2022 14:26, Andy Shevchenko wrote: > > On Thu, Dec 08, 2022 at 12:42:13PM +0200, Tomi Valkeinen wrote: > > > On 08/12/2022 12:39, Tomi Valkeinen wrote: ... > > > /** > > > - * Helper to add I2C ATR features to a device driver. > > > + * struct i2c_atr - Represents the I2C ATR instance > > > */ > > > > This is incomplete. Have you run kernel doc validator against this file? > > What's kernel doc validator? Do you mean that it's incomplete and kernel doc > doesn't work correctly, or that there should be more information here? > > I don't get any errors/warnings from any tool I have used. But I agree it > looks a bit odd with only the name of the struct in the doc. ... $ scripts/kernel-doc -none -v include/linux/i2c.h include/linux/i2c.h:79: warning: No description found for return value of 'i2c_master_recv' include/linux/i2c.h:94: warning: No description found for return value of 'i2c_master_recv_dmasafe' include/linux/i2c.h:109: warning: No description found for return value of 'i2c_master_send' include/linux/i2c.h:124: warning: No description found for return value of 'i2c_master_send_dmasafe' 4 warnings -- With Best Regards, Andy Shevchenko