From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF27EC001B2 for ; Thu, 8 Dec 2022 17:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbiLHRti (ORCPT ); Thu, 8 Dec 2022 12:49:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229847AbiLHRte (ORCPT ); Thu, 8 Dec 2022 12:49:34 -0500 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 375059B2A9 for ; Thu, 8 Dec 2022 09:49:33 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 091315C00DD; Thu, 8 Dec 2022 12:49:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 08 Dec 2022 12:49:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho.pizza; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1670521770; x=1670608170; bh=C8TXy9Fk8+ /VGu61vKrcCcU3jfSCcH0UL/PnmjTog/Q=; b=Ndnm5x+y48/6cXmUhP1+nDdC5i lNJHYEPZWgRBW1PdJNVR3wjlmNy+XFBovGBYHpqoKQ25dkUCoJXSkpX9ozd6UVRf pq2LfTp1YFmR2NNIFXeJx+BEM9ajCozSxXl5JueOZOlG3QbnGoE2EhMsYFPvogdr gUQ2hIu1BEDUGAYZQhScWg+3CDG4TgwiwMXbEgQRhFcKBJ97lczllSPUV15lzkWF c0JPaVhalfpXTh8ESVvY58Izii9eXt8fl3IJPibt1yrmvujwafEbsxoE1gf39JLy lwnocGQUZbasVZMuYw1XHoorPwsvEjY2X4Cg/CNsCVF31U/QxOyimXjP5iiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1670521770; x=1670608170; bh=C8TXy9Fk8+/VGu61vKrcCcU3jfSC cH0UL/PnmjTog/Q=; b=Rm8PX8MvBTjvGl6e464tif7hA3DfX/zV1jczJm7KnnKD R9XH9TybUEctphXVuh7IiH8LH3uQJKQUoaUDc/qAihbX6ewfalg1X2gHFg5QsTmR D2BNOXvcvLlIrrJMoHKMg9taJkbqq6YKs6+cH3BfL5cfSFPSk8d6H89ocENpopvq whvvxUfBZOq9AhpsoLuL2IOlLw7szYguht/fm90sVV6VAlQOiMA3fbtakFnkZGP8 YxKg18azrPb3XvSNSSenOGOxNIGrWO39sAcQNTPpx8S+GaDlmqEeJ8aDxG5w6ZNi 4RqC2YpoBZ/0m0Jlp4EAF7FHXitA2CkzzVs33M+q4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepvfihtghh ohcutehnuggvrhhsvghnuceothihtghhohesthihtghhohdrphhiiiiirgeqnecuggftrf grthhtvghrnhepueettdetgfejfeffheffffekjeeuveeifeduleegjedutdefffetkeel hfelleetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthihtghhohesthihtghhohdrphhiiiiirg X-ME-Proxy: Feedback-ID: i21f147d5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Dec 2022 12:49:28 -0500 (EST) Date: Thu, 8 Dec 2022 10:49:27 -0700 From: Tycho Andersen To: Miklos Szeredi Cc: Eric Biederman , linux-kernel@vger.kernel.org, fuse-devel@lists.sourceforge.net, "Serge E . Hallyn" Subject: Re: [PATCH v3] fuse: In fuse_flush only wait if someone wants the return code Message-ID: References: <20221114160209.1229849-1-tycho@tycho.pizza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 08, 2022 at 03:26:19PM +0100, Miklos Szeredi wrote: > On Mon, 28 Nov 2022 at 16:01, Tycho Andersen wrote: > > > > Hi Milkos, > > > > On Mon, Nov 14, 2022 at 09:02:09AM -0700, Tycho Andersen wrote: > > > v3: use schedule_work() to avoid other sleeps in inode_write_now() and > > > fuse_sync_writes(). Fix a UAF of the stack-based inarg. > > > > Thoughts on this version? > > Skipping attr invalidation on success is wrong. Agreed, that looks like my mistake. > How about the attached (untested) patch? It passes my reproducer with no warnings or anything. Feel free to add: Tested-by: Tycho Andersen if you want to commit it. Tycho