From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Matti Vaittinen" <Matti.Vaittinen@fi.rohmeurope.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Shawn Tu" <shawnx.tu@intel.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Mike Pagano" <mpagano@gentoo.org>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Marek Vasut" <marex@denx.de>
Subject: Re: [PATCH v5 3/8] dt-bindings: media: add bindings for TI DS90UB913
Date: Sun, 11 Dec 2022 19:13:08 +0200 [thread overview]
Message-ID: <Y5YPpGVJxAhkNJmC@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221208104006.316606-4-tomi.valkeinen@ideasonboard.com>
Hi Tomi,
Thank you for the patch.
On Thu, Dec 08, 2022 at 12:40:01PM +0200, Tomi Valkeinen wrote:
> Add DT bindings for TI DS90UB913 FPDLink-3 Serializer.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> .../bindings/media/i2c/ti,ds90ub913.yaml | 121 ++++++++++++++++++
> 1 file changed, 121 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
> new file mode 100644
> index 000000000000..3a5b34c6bb64
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
> @@ -0,0 +1,121 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub913.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments DS90UB913 FPD-Link 3 Serializer
I think TI consistently writes it "FPD-Link III". If you rename it,
please do so through the whole series.
> +
> +maintainers:
> + - Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> +
> +description:
> + The TI DS90UB913 is an FPD-Link 3 video serializer for parallel video.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,ds90ub913a-q1
Is the -q1 suffix needed, are there other variants ?
> +
> + '#gpio-cells':
> + const: 2
> +
> + gpio-controller: true
> +
> + clocks:
> + maxItems: 1
> + description:
> + Reference clock connected to the CLKIN pin.
> +
> + clock-names:
> + items:
> + - const: clkin
> +
> + '#clock-cells':
> + const: 0
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: CSI-2 input port
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + unevaluatedProperties: false
> + description: FPD-Link 3 output port
I'd add
required:
- port@0
- port@1
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> + i2c:
> + $ref: /schemas/i2c/i2c-controller.yaml#
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - '#gpio-cells'
> + - gpio-controller
> + - '#clock-cells'
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + serializer {
> + compatible = "ti,ds90ub913a-q1";
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + clocks = <&clk_cam_48M>;
> + clock-names = "clkin";
> +
> + #clock-cells = <0>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + ub913_in: endpoint {
> + remote-endpoint = <&sensor_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + endpoint {
> + remote-endpoint = <&deser_fpd_in>;
> + };
> + };
> + };
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor@48 {
> + compatible = "aptina,mt9v111";
> + reg = <0x48>;
> +
> + clocks = <&fixed_clock>;
> +
> + port {
> + sensor_out: endpoint {
> + remote-endpoint = <&ub913_in>;
> + };
> + };
> + };
> + };
> + };
> +...
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-12-11 17:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 10:39 [PATCH v5 0/8] i2c-atr and FPDLink Tomi Valkeinen
2022-12-08 10:39 ` [PATCH v5 1/8] i2c: core: let adapters be notified of client attach/detach Tomi Valkeinen
2022-12-08 12:30 ` Andy Shevchenko
2022-12-08 16:10 ` Tomi Valkeinen
2022-12-11 16:55 ` Laurent Pinchart
2022-12-19 8:51 ` Luca Ceresoli
2022-12-19 9:48 ` Andy Shevchenko
2022-12-26 16:54 ` Laurent Pinchart
2022-12-27 20:07 ` Andy Shevchenko
2022-12-08 10:40 ` [PATCH v5 2/8] i2c: add I2C Address Translator (ATR) support Tomi Valkeinen
2022-12-08 12:53 ` Andy Shevchenko
2022-12-08 16:01 ` Tomi Valkeinen
2022-12-08 18:09 ` Andy Shevchenko
2022-12-08 10:40 ` [PATCH v5 3/8] dt-bindings: media: add bindings for TI DS90UB913 Tomi Valkeinen
2022-12-11 17:13 ` Laurent Pinchart [this message]
2022-12-11 17:21 ` Laurent Pinchart
2022-12-13 13:36 ` Tomi Valkeinen
2022-12-26 16:46 ` Laurent Pinchart
2023-01-04 8:12 ` Tomi Valkeinen
2023-01-04 12:52 ` Laurent Pinchart
2022-12-13 13:21 ` Tomi Valkeinen
2022-12-08 10:40 ` [PATCH v5 4/8] dt-bindings: media: add bindings for TI DS90UB953 Tomi Valkeinen
2022-12-09 21:27 ` Rob Herring
2023-01-04 8:26 ` Tomi Valkeinen
2022-12-11 17:34 ` Laurent Pinchart
2022-12-13 14:06 ` Tomi Valkeinen
2022-12-08 10:40 ` [PATCH v5 5/8] dt-bindings: media: add bindings for TI DS90UB960 Tomi Valkeinen
2022-12-09 21:30 ` Rob Herring
2022-12-11 17:58 ` Laurent Pinchart
2022-12-13 14:25 ` Tomi Valkeinen
2022-12-26 16:52 ` Laurent Pinchart
2023-01-04 8:59 ` Tomi Valkeinen
2023-01-04 12:57 ` Laurent Pinchart
2023-01-04 14:05 ` Tomi Valkeinen
2023-01-05 6:54 ` Laurent Pinchart
2022-12-08 10:40 ` [PATCH v5 6/8] media: i2c: add DS90UB960 driver Tomi Valkeinen
2022-12-08 10:40 ` [PATCH v5 7/8] media: i2c: add DS90UB913 driver Tomi Valkeinen
2022-12-11 18:33 ` Laurent Pinchart
2022-12-14 6:29 ` Tomi Valkeinen
2022-12-14 6:36 ` Tomi Valkeinen
2022-12-26 16:56 ` Laurent Pinchart
2022-12-26 19:25 ` Tomi Valkeinen
2023-01-04 13:55 ` Laurent Pinchart
2023-01-04 14:13 ` Tomi Valkeinen
2023-01-04 15:32 ` Laurent Pinchart
2023-01-04 15:43 ` Tomi Valkeinen
2022-12-26 17:01 ` Laurent Pinchart
2022-12-27 20:09 ` Andy Shevchenko
2023-01-04 13:29 ` Laurent Pinchart
2022-12-14 6:48 ` Tomi Valkeinen
2022-12-08 10:40 ` [PATCH v5 8/8] media: i2c: add DS90UB953 driver Tomi Valkeinen
2022-12-08 10:42 ` [PATCH v5 0/8] i2c-atr and FPDLink Tomi Valkeinen
2022-12-08 12:26 ` Andy Shevchenko
2022-12-08 14:40 ` Tomi Valkeinen
2022-12-08 15:57 ` Andy Shevchenko
2022-12-08 15:58 ` Andy Shevchenko
2022-12-08 16:05 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5YPpGVJxAhkNJmC@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.tretter@pengutronix.de \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=mpagano@gentoo.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).