From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04331C10F1E for ; Tue, 13 Dec 2022 14:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235853AbiLMOyH (ORCPT ); Tue, 13 Dec 2022 09:54:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235895AbiLMOxq (ORCPT ); Tue, 13 Dec 2022 09:53:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5A25120B4; Tue, 13 Dec 2022 06:53:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3C3ACB81222; Tue, 13 Dec 2022 14:53:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8A62C433D2; Tue, 13 Dec 2022 14:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670943220; bh=0ssVJDgvZbB9LnC5sqEOsvKmP5VomXOUSJCqaAQ4RLI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b0l8P6ZVrL/TkvsRKU/S0gkk7uXRtpi0SZ5oltfRx3Sbl6NiGvi8oOpfEcCETte7+ JOmrM4kudD/MTa4lRbiXUPNgFfehwS0tfeoyjllnLFa43XbptpTi5+W7qkSb0Y9/bI OcmCtJ+DfRJeeA2iJmRkcuaI+AM4IGrcJGYIPBItI+lRH9vqtf+BeBv97mqaOKxDUr y6fYQQAzuu4eIssTVF46UumGB/Y3ZUaPa4i7ODBdZ323qO36MwK+y/vHE/6KNRwbcA qO/SRTRxcOMluig5biLiT0UjdTHZlwS5XigC/1TUJ3wqDgPr/4xUUPVeZ2QrSfDxn7 +sq9CIf3MPbyQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1p56fV-0004hh-Ob; Tue, 13 Dec 2022 15:54:05 +0100 Date: Tue, 13 Dec 2022 15:54:05 +0100 From: Johan Hovold To: Brian Masney Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ahalaney@redhat.com, echanude@redhat.com, quic_shazhuss@quicinc.com Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc8280xp: rename i2c5 to i2c21 Message-ID: References: <20221212182314.1902632-1-bmasney@redhat.com> <20221212182314.1902632-2-bmasney@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221212182314.1902632-2-bmasney@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 12, 2022 at 01:23:11PM -0500, Brian Masney wrote: > According to the downstream 5.4 kernel sources for the sa8540p, > i2c@894000 is labeled i2c bus 21, not 5. The interrupts and clocks > also match. Let's go ahead and correct the name that's used in the > three files where this is listed. > > Signed-off-by: Brian Masney > Fixes: 152d1faf1e2f3 ("arm64: dts: qcom: add SC8280XP platform") > Fixes: ccd3517faf183 ("arm64: dts: qcom: sc8280xp: Add reference device") > Fixes: 32c231385ed43 ("arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree") > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 109c9d2b684d..875cc91324ce 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -827,7 +827,7 @@ qup2_uart17: serial@884000 { > status = "disabled"; > }; > > - qup2_i2c5: i2c@894000 { > + qup2_i2c21: i2c@894000 { Note that the node is labelled qup2_i2c5 and not qup_i2c5. That is, the QUP nodes are labelled using two indices, and specifically qup2_i2c5 would be another name for qup_i2c21 if we'd been using such a flat naming scheme (there are 8 engines per QUP). So there's nothing wrong with how these nodes are currently named, but mixing the two scheme as you are suggesting would not be correct. Johan