From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
david.keisarschm@mail.huji.ac.il,
dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org,
linux-scsi@vger.kernel.org, linux-mm@kvack.org,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state
Date: Wed, 14 Dec 2022 17:53:51 +0200 [thread overview]
Message-ID: <Y5nxjzV0Mio86NU6@smile.fi.intel.com> (raw)
In-Reply-To: <CANn89iJtK4m1cWvCwp=L_rEOEBa+B1kLZJAw0D9_cYPQcAj+Mw@mail.gmail.com>
On Wed, Dec 14, 2022 at 04:15:49PM +0100, Eric Dumazet wrote:
> On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka
> <stanislaw.gruszka@linux.intel.com> wrote:
> > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote:
> > > Please CC me on future revisions.
> > >
> > > As of 6.2, the prandom namespace is *only* for predictable randomness.
> > > There's no need to rename anything. So nack on this patch 1/5.
> >
> > It is not obvious (for casual developers like me) that p in prandom
> > stands for predictable. Some renaming would be useful IMHO.
>
> Renaming makes backports more complicated, because stable teams will
> have to 'undo' name changes.
> Stable teams are already overwhelmed by the amount of backports, and
> silly merge conflicts.
>
> Take another example :
>
> u64 timecounter_read(struct timecounter *tc)
>
> You would think this function would read the timecounter, right ?
>
> Well, it _updates_ many fields from @tc, so a 'better name' would also
> be useful.
Right, at some point we become into the world of
#define true 0
because... (read below)
> linux kernel is not for casual readers.
P.S. I believe you applied a common sense and in some cases
the renames are necessary.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-14 15:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1670778651.git.david.keisarschm@mail.huji.ac.il>
2022-12-11 22:16 ` [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state david.keisarschm
2022-12-12 8:35 ` Andy Shevchenko
2022-12-12 14:35 ` Jason A. Donenfeld
2022-12-14 12:33 ` Stanislaw Gruszka
2022-12-14 15:15 ` Eric Dumazet
2022-12-14 15:53 ` Andy Shevchenko [this message]
2022-12-14 15:57 ` Andy Shevchenko
2022-12-14 16:21 ` Stanislaw Gruszka
2022-12-14 18:28 ` Theodore Ts'o
2022-12-11 22:16 ` [PATCH 2/5] Replace invocation of weak PRNG in kernel/bpf/core.c david.keisarschm
2022-12-12 18:03 ` Yonghong Song
2022-12-12 22:35 ` Amit Klein
2022-12-12 22:41 ` Jason A. Donenfeld
2022-12-11 22:16 ` [PATCH 3/5] Replace invocation of weak PRNG in mm/slab.c david.keisarschm
2022-12-11 22:16 ` [PATCH 4/5] Replace invocation of weak PRNG inside mm/slab_common.c david.keisarschm
2022-12-11 22:16 ` [PATCH 5/5] Replace invocation of weak PRNG in arch/x86/mm/kaslr.c david.keisarschm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5nxjzV0Mio86NU6@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=david.keisarschm@mail.huji.ac.il \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).