Re: [PATCH] perf arm64: Fix mksyscalltbl, don't lose syscalls due to sort -nu

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Leo Yan <leo.yan@linaro.org>,
	Vincent Whitchurch <vincent.whitchurch@axis.com>,
	Hans-Peter Nilsson <hp@axis.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, John Garry <john.garry@huawei.com>,
	Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Kim Phillips <kim.phillips@arm.com>
Subject: Re: [PATCH] perf arm64: Fix mksyscalltbl, don't lose syscalls due to sort -nu
Date: Wed, 21 Dec 2022 17:15:15 -0300	[thread overview]
Message-ID: <Y6NpUyLRR0f9sQ9C@kernel.org> (raw)
In-Reply-To: <98978f82-eb78-4fa7-901e-76c3070362e3@app.fastmail.com>

Em Fri, Nov 25, 2022 at 02:56:31PM +0100, Arnd Bergmann escreveu:
> On Fri, Nov 25, 2022, at 13:54, Leo Yan wrote:
> > On Fri, Nov 25, 2022 at 12:53:10PM +0100, Vincent Whitchurch wrote:
> 
> >> It looks like this patch was never applied?  AFAICS it is still needed
> >> on current HEAD and it still applies cleanly.
> >
> > Thanks a lot for bringing up this.
> >
> > Before there have a discussion [1] for refactoring Arm64 system call
> > table but it didn't really happen.
> 
> I actually worked on this last week and did a new series to convert
> the old asm-generic/unistd.h header into the syscall.tbl format,
> and change arm64 to use that.
> 
> You can find my work in the 'syscall-tbl' branch of my asm-generic
> tree [1]. This has only seen light build testing so far, and is
> probably still buggy, but most of the work is there. The missing
> bits are the Makefiles for the other seven architectures using
> asm-generic/unistd.h, and checking the output to ensure the
> contents are still the same.
> 
> > I think it's the right thing to merge
> > this patch, @Arnaldo, could you pick up this patch?

So I'm adding the provided:

Reviewed-by: Leo Yan <leo.yan@linaro.org>
Tested-by: Leo Yan <leo.yan@linaro.org>

> That sounds fine to me.

And taking this as an:

Acked-by: Arnd Bergmann <arnd@arndb.de>

ok?

- Arnaldo

>     Arnd
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/