From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/2] iio: adc: ti-adc128s052: Switch to use spi_get_device_match_data()
Date: Wed, 28 Dec 2022 11:59:53 +0200 [thread overview]
Message-ID: <Y6wTmapfACknDKO8@smile.fi.intel.com> (raw)
In-Reply-To: <20221223154450.458771b8@jic23-huawei>
On Fri, Dec 23, 2022 at 03:44:50PM +0000, Jonathan Cameron wrote:
> On Fri, 23 Dec 2022 15:22:42 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Wed, 14 Dec 2022 13:49:43 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > The spi_get_device_match_data() helps to get driver data from the
> > > firmware node or SPI ID table. Use it instead of open coding.
> > >
> > > While at it, switch ID tables to provide an acrual pointers to
> > > the configuration data.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >
> > > Requires aea672d054a2 ("spi: Introduce spi_get_device_match_data()
> > > helper") which is part of upstream as of today.
> >
> > I rebased to get that (will rebase again on rc1).
> >
> > Applied to the togreg branch of iio.git and pushed out as testing
> > to keep 0-day busy over my holidays.
>
> I take it back... Build test failed...
As comment on the first patch stays this requires an SPI core patch, which is
now the part of the v6.2-rc1.
Can you reapply it taking the above into consideration?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-28 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 11:49 [PATCH v1 1/2] iio: adc: ti-adc128s052: Switch to use spi_get_device_match_data() Andy Shevchenko
2022-12-14 11:49 ` [PATCH v1 2/2] iio: adc: ti-adc128s052: Drop anti-pattern of ACPI_PTR() use Andy Shevchenko
2022-12-23 15:24 ` Jonathan Cameron
2022-12-14 13:10 ` [PATCH v1 1/2] iio: adc: ti-adc128s052: Switch to use spi_get_device_match_data() kernel test robot
2022-12-14 17:02 ` kernel test robot
2022-12-23 15:22 ` Jonathan Cameron
2022-12-23 15:44 ` Jonathan Cameron
2022-12-28 9:59 ` Andy Shevchenko [this message]
2022-12-31 14:45 ` Jonathan Cameron
2022-12-31 18:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6wTmapfACknDKO8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).