From: Frederic Weisbecker <frederic@kernel.org>
To: Christoph Lameter <cl@gentwo.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
atomlin@atomlin.com, tglx@linutronix.de, mingo@kernel.org,
peterz@infradead.org, pauld@redhat.com, neelx@redhat.com,
oleksandr@natalenko.name, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v13 2/6] mm/vmstat: Use vmstat_dirty to track CPU-specific vmstat discrepancies
Date: Tue, 10 Jan 2023 13:18:46 +0100 [thread overview]
Message-ID: <Y71XpnJGumySL9ej@lothringen> (raw)
In-Reply-To: <b89a9828-d4e-9874-d482-dbb6cbe46@gentwo.de>
On Tue, Jan 10, 2023 at 01:06:37PM +0100, Christoph Lameter wrote:
> On Thu, 5 Jan 2023, Marcelo Tosatti wrote:
> > @@ -577,6 +579,9 @@ static inline void mod_zone_state(struct
> > s8 __percpu *p = pcp->vm_stat_diff + item;
> > long o, n, t, z;
> >
> > + /* cmpxchg and vmstat_mark_dirty should happen on the same CPU */
> > + preempt_disable();
>
> If you are disabling preemption then why do we still need cmpxchg?
> Same again below.
Note I'm absolutely clueless with vmstat. But I was wondering about it as well
while reviewing Marcelo's series, so git blame pointed me to:
7c83912062c801738d7d19acaf8f7fec25ea663c ("vmstat: User per cpu atomics to avoid
interrupt disable / enable")
And this seem to mention that this can race with IRQs as well, hence the local
cmpxchg operation.
next prev parent reply other threads:[~2023-01-10 12:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 12:52 [PATCH v13 0/6] Ensure quiet_vmstat() is called when returning to userpace and when idle tick is stopped Marcelo Tosatti
2023-01-05 12:52 ` [PATCH v13 1/6] mm/vmstat: Add CPU-specific variable to track a vmstat discrepancy Marcelo Tosatti
2023-01-10 11:58 ` Christoph Lameter
2023-01-10 12:12 ` Frederic Weisbecker
2023-01-05 12:52 ` [PATCH v13 2/6] mm/vmstat: Use vmstat_dirty to track CPU-specific vmstat discrepancies Marcelo Tosatti
2023-01-10 12:06 ` Christoph Lameter
2023-01-10 12:18 ` Frederic Weisbecker [this message]
2023-01-10 13:39 ` Christoph Lameter
2023-01-10 20:09 ` Marcelo Tosatti
2023-01-11 8:42 ` Christoph Lameter
2023-01-11 17:07 ` Marcelo Tosatti
2023-01-16 9:51 ` Christoph Lameter
2023-01-16 16:11 ` Marcelo Tosatti
2023-01-17 12:52 ` Christoph Lameter
2023-01-05 12:52 ` [PATCH v13 3/6] mm/vmstat: manage per-CPU stats from CPU context when NOHZ full Marcelo Tosatti
2023-01-05 12:52 ` [PATCH v13 4/6] tick/nohz_full: Ensure quiet_vmstat() is called on exit to user-mode when the idle tick is stopped Marcelo Tosatti
2023-01-05 12:52 ` [PATCH v13 5/6] tick/sched: Ensure quiet_vmstat() is called when the idle tick was stopped too Marcelo Tosatti
2023-01-05 12:52 ` [PATCH v13 6/6] mm/vmstat: avoid queueing work item if cpu stats are clean Marcelo Tosatti
[not found] ` <20230106001244.4463-1-hdanton@sina.com>
2023-01-06 12:51 ` [PATCH v13 3/6] mm/vmstat: manage per-CPU stats from CPU context when NOHZ full Marcelo Tosatti
[not found] ` <20230106150154.4560-1-hdanton@sina.com>
2023-01-06 18:16 ` Marcelo Tosatti
[not found] ` <20230107001529.4617-1-hdanton@sina.com>
2023-01-09 14:12 ` Marcelo Tosatti
[not found] ` <20230110024356.336-1-hdanton@sina.com>
2023-01-10 11:50 ` Marcelo Tosatti
[not found] ` <20230110151901.402-1-hdanton@sina.com>
2023-01-10 16:12 ` Frederic Weisbecker
[not found] ` <20230110235822.456-1-hdanton@sina.com>
2023-01-11 0:09 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y71XpnJGumySL9ej@lothringen \
--to=frederic@kernel.org \
--cc=atomlin@atomlin.com \
--cc=cl@gentwo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=neelx@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).