From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Jisheng Zhang <jszhang@kernel.org>,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Andre Przywara <andre.przywara@arm.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor@kernel.org>,
linux-kernel@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH v4 07/12] riscv: dts: allwinner: Add Sipeed Lichee RV devicetrees
Date: Tue, 10 Jan 2023 16:58:06 +0100 [thread overview]
Message-ID: <Y72LDlIOYo/I8dii@aptenodytes> (raw)
In-Reply-To: <05c1ee07-0750-d40e-8498-55ea07b52ab1@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
Hi Samuel,
On Sun 08 Jan 23, 12:42, Samuel Holland wrote:
> Hi Paul,
>
> On 1/5/23 07:55, Paul Kocialkowski wrote:
> > Hi Samuel,
> >
> > On Sat 31 Dec 22, 17:38, Samuel Holland wrote:
> >> Sipeed manufactures a "Lichee RV" system-on-module, which provides a
> >> minimal working system on its own, as well as a few carrier boards. The
> >> "Dock" board provides audio, USB, and WiFi. The "86 Panel" additionally
> >> provides 100M Ethernet and a built-in display panel.
> >>
> >> The 86 Panel repurposes the USB ID and VBUS detection GPIOs for its RGB
> >> panel interface, since the USB OTG port is inaccessible inside the case.
> >
> > Looks like the panel-enabled variants would better be described as device-tree
> > overlays as they are not specific devices but are peripheral extensions.
> >
> > What do you think?
>
> I don't agree. The Lichee RV 86 Panel is sold as a complete unit, with
> the SoM+board and LCD pre-assembled inside a case. It is not possible to
> purchase the board without a panel, so the panel-enabled variants are
> the only variants.
Oh my bad, I didn't go as far as actually checking what it looks like.
So yeah if it's an individual device on its own I agree it deserves its
own dedicated device-tree.
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-10 15:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 23:38 [PATCH v4 00/12] riscv: Allwinner D1/D1s platform support Samuel Holland
2022-12-31 23:38 ` [PATCH v4 01/12] MAINTAINERS: Match the sun20i family of Allwinner SoCs Samuel Holland
2022-12-31 23:38 ` [PATCH v4 02/12] dt-bindings: vendor-prefixes: Add Allwinner D1/D1s board vendors Samuel Holland
2022-12-31 23:38 ` [PATCH v4 03/12] dt-bindings: riscv: Add Allwinner D1/D1s board compatibles Samuel Holland
2022-12-31 23:38 ` [PATCH v4 04/12] riscv: dts: allwinner: Add the D1/D1s SoC devicetree Samuel Holland
2023-01-03 11:06 ` Andre Przywara
2022-12-31 23:38 ` [PATCH v4 05/12] riscv: dts: allwinner: Add MangoPi MQ devicetree Samuel Holland
2022-12-31 23:38 ` [PATCH v4 06/12] riscv: dts: allwinner: Add Allwinner D1 Nezha devicetree Samuel Holland
2022-12-31 23:38 ` [PATCH v4 07/12] riscv: dts: allwinner: Add Sipeed Lichee RV devicetrees Samuel Holland
2023-01-05 13:55 ` Paul Kocialkowski
2023-01-08 18:42 ` Samuel Holland
2023-01-10 15:58 ` Paul Kocialkowski [this message]
2022-12-31 23:38 ` [PATCH v4 08/12] riscv: dts: allwinner: Add MangoPi MQ Pro devicetree Samuel Holland
2022-12-31 23:38 ` [PATCH v4 09/12] riscv: dts: allwinner: Add Dongshan Nezha STU devicetree Samuel Holland
2022-12-31 23:38 ` [PATCH v4 10/12] riscv: dts: allwinner: Add ClockworkPi and DevTerm devicetrees Samuel Holland
2022-12-31 23:38 ` [PATCH v4 11/12] riscv: Add the Allwinner SoC family Kconfig option Samuel Holland
2022-12-31 23:38 ` [PATCH v4 12/12] riscv: defconfig: Enable the Allwinner D1 platform and drivers Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y72LDlIOYo/I8dii@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).