From: Mark Brown <broonie@kernel.org>
To: Janne Grunau <j@jannau.net>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hector Martin <marcan@marcan.st>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
asahi@lists.linux.dev, linux-kernel@vger.kernel.org,
Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH 3/5] spi: Use a 32-bit DT property for spi-cs-setup-delay-ns
Date: Fri, 6 Jan 2023 16:26:23 +0000 [thread overview]
Message-ID: <Y7hLrxQO9GbgpW1h@sirena.org.uk> (raw)
In-Reply-To: <20230104093631.15611-4-marcan@marcan.st>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
On Wed, Jan 04, 2023 at 06:36:29PM +0900, Janne Grunau wrote:
> 65us is not a reasonable maximum for this property, as some devices
> might need a much longer setup time (e.g. those driven by firmware on
> the other end). Plus, device tree property values are in 32-bit cells
> and smaller widths should not be used without good reason.
This breaks allmodconfig builds (I tested x86 but this should happen
for anything with -Werror):
/build/stage/linux/drivers/spi/spi.c: In function ‘of_spi_parse_dt’:
/build/stage/linux/drivers/spi/spi.c:2243:13: error: unused variable ‘cs_setup’ [-Werror=unused-variable]
2243 | u16 cs_setup;
| ^~~~~~~~
cc1: all warnings being treated as errors
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-06 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:36 [PATCH 0/5] SPI core CS delay fixes and additions Hector Martin
2023-01-04 9:36 ` [PATCH 1/5] spi: dt-bindings: Rename spi-cs-setup-ns to spi-cs-setup-delay-ns Hector Martin
2023-01-04 9:36 ` [PATCH 2/5] spi: Rename spi-cs-setup-ns property " Hector Martin
2023-01-04 9:36 ` [PATCH 3/5] spi: Use a 32-bit DT property for spi-cs-setup-delay-ns Hector Martin
2023-01-06 16:26 ` Mark Brown [this message]
2023-01-06 16:40 ` Hector Martin
2023-01-06 18:34 ` Mark Brown
2023-01-04 9:36 ` [PATCH 4/5] spi: dt-bindings: Add hold/inactive CS delay peripheral properties Hector Martin
2023-01-08 21:31 ` Rob Herring
2023-01-04 9:36 ` [PATCH 5/5] spi: Parse hold/inactive CS delay values from the DT Hector Martin
2023-01-06 16:33 ` [PATCH 0/5] SPI core CS delay fixes and additions Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7hLrxQO9GbgpW1h@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).