From: Sam Ravnborg <sam@ravnborg.org>
To: Stephen Kitt <steve@sk2.org>
Cc: Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org, Helge Deller <deller@gmx.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper
Date: Fri, 6 Jan 2023 19:26:16 +0100 [thread overview]
Message-ID: <Y7hnyCOlWuJf+obV@ravnborg.org> (raw)
In-Reply-To: <20230106164856.1453819-4-steve@sk2.org>
On Fri, Jan 06, 2023 at 05:48:54PM +0100, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/video/backlight/ipaq_micro_bl.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/ipaq_micro_bl.c b/drivers/video/backlight/ipaq_micro_bl.c
> index 85b16cc82878..f595b8c8cbb2 100644
> --- a/drivers/video/backlight/ipaq_micro_bl.c
> +++ b/drivers/video/backlight/ipaq_micro_bl.c
> @@ -16,17 +16,12 @@
> static int micro_bl_update_status(struct backlight_device *bd)
> {
> struct ipaq_micro *micro = dev_get_drvdata(&bd->dev);
> - int intensity = bd->props.brightness;
> + int intensity = backlight_get_brightness(bd);
> struct ipaq_micro_msg msg = {
> .id = MSG_BACKLIGHT,
> .tx_len = 3,
> };
>
> - if (bd->props.power != FB_BLANK_UNBLANK)
> - intensity = 0;
> - if (bd->props.state & (BL_CORE_FBBLANK | BL_CORE_SUSPENDED))
> - intensity = 0;
> -
> /*
> * Message format:
> * Byte 0: backlight instance (usually 1)
> --
> 2.30.2
next prev parent reply other threads:[~2023-01-06 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 16:48 [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper Stephen Kitt
2023-01-06 18:26 ` Sam Ravnborg [this message]
2023-01-09 10:17 ` Daniel Thompson
2023-01-19 21:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7hnyCOlWuJf+obV@ravnborg.org \
--to=sam@ravnborg.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).