From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5DA0C54EBD for ; Fri, 6 Jan 2023 20:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbjAFUpj (ORCPT ); Fri, 6 Jan 2023 15:45:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235859AbjAFUpd (ORCPT ); Fri, 6 Jan 2023 15:45:33 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DE70669BD for ; Fri, 6 Jan 2023 12:45:30 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D36811EC02F2; Fri, 6 Jan 2023 21:45:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1673037928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=eYV8zDhpGymcSl64VHc8NEHhSI4QfjSkII09GWz28kA=; b=Y9UTH6LD331tb/ZtXpZBzRV0p2J01HmX5B11P9yxRcWvqQL/RZ6oTqe/VAyOn2UnILGzkP ZPidtn8JSrTw602Ytn9zBNUzFHdXjDQvQyCG8YhxKwmkeSGGUefBPSD8CzEGJE1wttM+sV 9watab/4LiVCPRrIvAa7OBRJqGuAh6I= Date: Fri, 6 Jan 2023 21:45:24 +0100 From: Borislav Petkov To: Ashok Raj Cc: Thomas Gleixner , X86-kernel , LKML Mailing List , Dave Hansen , Tony Luck , Alison Schofield , Reinette Chatre , Tom Lendacky Subject: Re: [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful Message-ID: References: <20230103180212.333496-1-ashok.raj@intel.com> <20230103180212.333496-4-ashok.raj@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2023 at 12:29:00PM -0800, Ashok Raj wrote: > Yes, that makes sense, Do you think we can add a note that the loading > failed? since the old -> new, new is coming from new microcode rev. It has failed when old == new. I.e., "microcode revision: 0x1a -> 0x1a" when the current revision on the CPU is 0x1a. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette