linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
	LKML Mailing List <linux-kernel@vger.kernel.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Tony Luck <tony.luck@intel.com>, Ingo Molnar <mingo@kernel.org>,
	alison.schofield@intel.com, reinette.chatre@intel.com,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v4 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev()
Date: Sun, 15 Jan 2023 20:25:14 +0100	[thread overview]
Message-ID: <Y8RTGguX9yXoEGKv@zn.tnic> (raw)
In-Reply-To: <20230109153555.4986-5-ashok.raj@intel.com>

On Mon, Jan 09, 2023 at 07:35:53AM -0800, Ashok Raj wrote:
> @@ -343,33 +340,23 @@ void show_ucode_info_early(void)
>   * At this point, we can not call printk() yet. Delay printing microcode info in
>   * show_ucode_info_early() until printk() works.
>   */
> -static void print_ucode(struct ucode_cpu_info *uci)
> +static void print_ucode(int new_rev, int date)
>  {
>  	struct microcode_intel *mc;
>  	int *delay_ucode_info_p;
>  	int *current_mc_date_p;
>  
> -	mc = uci->mc;
> -	if (!mc)
> -		return;
> -
>  	delay_ucode_info_p = (int *)__pa_nodebug(&delay_ucode_info);
>  	current_mc_date_p = (int *)__pa_nodebug(&current_mc_date);
>  
>  	*delay_ucode_info_p = 1;
> -	*current_mc_date_p = mc->hdr.date;
> +	*current_mc_date_p = date;

Here's how I know you haven't tested this on 32-bit:

arch/x86/kernel/cpu/microcode/intel.c: In function ‘print_ucode’:
arch/x86/kernel/cpu/microcode/intel.c:344:33: error: unused variable ‘mc’ [-Werror=unused-variable]
  344 |         struct microcode_intel *mc;
      |                                 ^~
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:252: arch/x86/kernel/cpu/microcode/intel.o] Error 1
make[4]: *** [scripts/Makefile.build:504: arch/x86/kernel/cpu/microcode] Error 2
make[3]: *** [scripts/Makefile.build:504: arch/x86/kernel/cpu] Error 2
make[2]: *** [scripts/Makefile.build:504: arch/x86/kernel] Error 2
make[1]: *** [scripts/Makefile.build:504: arch/x86] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:2008: .] Error 2

Testing is overrated, right?

The maintainers can do that, ofc.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2023-01-15 19:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 15:35 [PATCH v4 0/6] Some fixes and cleanups for microcode Ashok Raj
2023-01-09 15:35 ` [PATCH v4 1/6] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities Ashok Raj
2023-01-21 14:54   ` [tip: x86/microcode] " tip-bot2 for Ashok Raj
2023-01-09 15:35 ` [PATCH v4 2/6] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2023-01-21 14:54   ` [tip: x86/microcode] x86/microcode: Check CPU capabilities after late microcode update correctly tip-bot2 for Ashok Raj
2023-01-09 15:35 ` [PATCH v4 3/6] x86/microcode: Display revisions only when update is successful Ashok Raj
2023-01-09 15:35 ` [PATCH v4 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() Ashok Raj
2023-01-15 19:25   ` Borislav Petkov [this message]
2023-01-15 19:39   ` Borislav Petkov
2023-01-17 16:05     ` Ashok Raj
2023-01-17 18:16       ` Borislav Petkov
2023-01-09 15:35 ` [PATCH v4 5/6] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2023-01-09 15:35 ` [PATCH v4 6/6] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
2023-01-15 19:05   ` Borislav Petkov
2023-01-17 16:12     ` Ashok Raj
2023-01-17 16:29       ` Dave Hansen
2023-01-17 18:21         ` Borislav Petkov
2023-01-17 18:32           ` Dave Hansen
2023-01-17 18:40             ` Borislav Petkov
2023-01-17 20:40               ` Ashok Raj
2023-01-17 20:58                 ` Luck, Tony
2023-01-19 17:59                   ` Ashok Raj
2023-01-20 12:03                     ` Borislav Petkov
2023-01-20 16:52                       ` Ashok Raj
2023-01-17 21:00                 ` Dave Hansen
2023-01-17 21:06                 ` Borislav Petkov
2023-01-17 21:34                   ` Ashok Raj
2023-01-17 19:10             ` Ashok Raj
2023-01-17 16:35   ` Dave Hansen
2023-01-17 17:59     ` Ashok Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8RTGguX9yXoEGKv@zn.tnic \
    --to=bp@alien8.de \
    --cc=alison.schofield@intel.com \
    --cc=ashok.raj@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).