From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6933BC38141 for ; Fri, 20 Jan 2023 16:00:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbjATQAP (ORCPT ); Fri, 20 Jan 2023 11:00:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjATQAN (ORCPT ); Fri, 20 Jan 2023 11:00:13 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB2945E522; Fri, 20 Jan 2023 08:00:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674230412; x=1705766412; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WRsyLGOahjzjt6kpSNh9GKMvG+H+i5eITtoKdM1H0Zk=; b=EE3gOSkkR3ardASQQfhOrYpPbphD88W4DAPjVsWFPl1m2cDgazcRvH5p wAMcqZ5/AT0/BWUJjCA/g0B+/ucRXFkS+ejUCX5RBBbhvOS6cvmbGs+Pc YcbMDl5fJFQYOFmQ4l+s77ELBKHmQPOgUwnduvzeRitvyxhiXapfT4poZ PcRxkDDC0D6ZQuo7RqMZMOyKBFXRCer3e2H+v2Ur+Hl4VWP24xhYG3zHB LJefgzHpslfg3CwedhEyNoQH/6UlegLiBo9TorqHfle0Z7UouPWY0q1SG k+yhr2FPHCxBUglHW0i+uh4sT/lpUcMOlljQ0sp36SPCfmP156yXA6B5T A==; X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="313495260" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="313495260" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 08:00:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="749380190" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="749380190" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jan 2023 08:00:05 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pItoA-00CIej-1G; Fri, 20 Jan 2023 18:00:02 +0200 Date: Fri, 20 Jan 2023 18:00:02 +0200 From: Andy Shevchenko To: Luca Ceresoli Cc: Tomi Valkeinen , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Wolfram Sang , Matti Vaittinen , Laurent Pinchart , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Sakari Ailus , Michael Tretter , Shawn Tu , Hans Verkuil , Mike Pagano , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut Subject: Re: [PATCH v7 0/7] i2c-atr and FPDLink Message-ID: References: <20230118124031.788940-1-tomi.valkeinen@ideasonboard.com> <20230119094358.010bc826@booty> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119094358.010bc826@booty> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2023 at 09:43:58AM +0100, Luca Ceresoli wrote: > On Wed, 18 Jan 2023 19:43:23 +0200 > Andy Shevchenko wrote: > > On Wed, Jan 18, 2023 at 07:28:20PM +0200, Tomi Valkeinen wrote: > > > On 18/01/2023 18:01, Andy Shevchenko wrote: > > > > On Wed, Jan 18, 2023 at 02:40:24PM +0200, Tomi Valkeinen wrote: ... > > > Can you clarify what you mean here? > > > > > > The i2c_clients are not aware of the i2c-atr. They are normal i2c clients. > > > The FPD-Link drivers are aware of the ATR, as the FPD-Link hardware contains > > > the ATR support. > > > > Can't that hardware be represented as I2C adapter? In such case the ATR specifics > > can be hidden from the client (drivers). > > > > I'm worrying about code duplication and other things that leak into drivers as > > ATR callbacks. > > Which callbacks do you refer to? i2c_atr_ops? I don't think we can do > without the attach/detach_client ones, it's where the driver-specific > implementation is hooked for the generic ATR infra to call it. > > However now I noticed the select/deselect ops are still there. IIRC > they are not used by any driver and in the past the plan was to just > remove them. Tomi, do you think there is a good reason to keep them? > > > It might be that I didn't get how hw exactly functioning on this > > level and why we need those callbacks. > > As far as "how hw exactly works", in case you haven't seen that, the > best explanation I was able to give is in my ELCE 2019 talk, at minute > ~22. It's a 2-3 minute watch. The slides have pointers to other talks > and discussion. Probably I have missed the URL in the discussion, care to resend? -- With Best Regards, Andy Shevchenko