linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Pantyukhin <apantykhin@gmail.com>
Cc: hch@lst.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kib/uuid.c: add check for length for uuid_is_valid
Date: Sat, 21 Jan 2023 12:50:01 +0200	[thread overview]
Message-ID: <Y8vDWYDoyIiWpg9N@smile.fi.intel.com> (raw)
In-Reply-To: <20230120213802.2467-1-apantykhin@gmail.com>

On Sat, Jan 21, 2023 at 02:38:02AM +0500, Alexander Pantyukhin wrote:

Thank you for the patch.

> Add check for length strict equality for uuid is valid

UUID

Missing period at the end of sentence.

...

Why do you think it's a problem?

Have you checked all callers if they strictly using this API and not to parse
something like:

	UUID ...other data...\0

?

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2023-01-21 10:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 21:38 [PATCH] kib/uuid.c: add check for length for uuid_is_valid Alexander Pantyukhin
2023-01-21 10:50 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8vDWYDoyIiWpg9N@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=apantykhin@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).