From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] mfd: Make .disable() callback return void
Date: Thu, 26 Jan 2023 13:34:16 +0000 [thread overview]
Message-ID: <Y9KBWKNJQo0yCw2I@google.com> (raw)
In-Reply-To: <20230113182427.257484-2-u.kleine-koenig@pengutronix.de>
On Fri, 13 Jan 2023, Uwe Kleine-König wrote:
> All implementations return 0 unconditionally, so change the prototype to
> return void. This allows to get rid of error handling in callers that
> isn't actually used.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/mfd/asic3.c | 17 +++++++++--------
> drivers/mfd/htc-pasic3.c | 3 +--
> drivers/mfd/mfd-core.c | 4 +++-
> drivers/mfd/t7l66xb.c | 4 +---
> drivers/mfd/tc6387xb.c | 4 +---
> drivers/mfd/tc6393xb.c | 16 ++++++++++------
> include/linux/mfd/core.h | 2 +-
> 7 files changed, 26 insertions(+), 24 deletions(-)
Doesn't apply to the MFD tree.
Please rebase and I'll merge it.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-01-26 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 18:24 [PATCH 0/2] mfd: Make .disable() callback and mfd_cell_disable() return void Uwe Kleine-König
2023-01-13 18:24 ` [PATCH 1/2] mfd: Make .disable() callback " Uwe Kleine-König
2023-01-26 13:34 ` Lee Jones [this message]
2023-01-26 15:27 ` Uwe Kleine-König
2023-01-13 18:24 ` [PATCH 2/2] mfd: Make mfd_cell_disable() " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9KBWKNJQo0yCw2I@google.com \
--to=lee@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).