From: Johan Hovold <johan@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Jeremy Kerr <jk@ozlabs.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Steev Klimaszewski <steev@kali.org>
Subject: Re: [PATCH] efivarfs: fix NULL-deref on mount when no efivars
Date: Fri, 27 Jan 2023 09:28:11 +0100 [thread overview]
Message-ID: <Y9OLG5/yeuG6KT0f@hovoldconsulting.com> (raw)
In-Reply-To: <CAMj1kXEUKChvqA8D_T3Bt-pQhvjBmsGxyy69uqDqyn0EBmQ1pw@mail.gmail.com>
On Thu, Jan 26, 2023 at 09:32:27PM +0100, Ard Biesheuvel wrote:
> On Thu, 26 Jan 2023 at 12:23, Johan Hovold <johan+linaro@kernel.org> wrote:
> >
> > The VFS calls kill_sb() also in case mount fails in get_tree().
> >
> > Add the missing check to make sure that efivars has been registered also
> > to kill_sb() to avoid dereferencing a NULL pointer when trying to remove
> > efivar entries.
> >
> > Fixes: c3fd71b428b8 ("efivarfs: always register filesystem")
> > Reported-by: Steev Klimaszewski <steev@kali.org>
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> Thanks - I have squashed this with the original patch.
Thanks, Ard. And sorry about not catching this before posting.
Johan
next prev parent reply other threads:[~2023-01-27 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 11:21 [PATCH] efivarfs: fix NULL-deref on mount when no efivars Johan Hovold
2023-01-26 20:32 ` Ard Biesheuvel
2023-01-27 8:28 ` Johan Hovold [this message]
2023-01-27 8:38 ` Ard Biesheuvel
2023-02-23 9:03 ` kernel test robot
2023-02-24 8:02 ` Johan Hovold
2023-02-23 10:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9OLG5/yeuG6KT0f@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=ardb@kernel.org \
--cc=jk@ozlabs.org \
--cc=johan+linaro@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).