From: Andrew Lunn <andrew@lunn.ch>
To: Chris Healy <cphealy@gmail.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
neil.armstrong@linaro.org, khilman@baylibre.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
jeremy.wang@amlogic.com, Chris Healy <healych@amazon.com>
Subject: Re: [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD register access
Date: Sun, 29 Jan 2023 22:53:17 +0100 [thread overview]
Message-ID: <Y9bqzZw4z6JWGeI6@lunn.ch> (raw)
In-Reply-To: <CAFXsbZppb5tDxR9tO7RN76=rt04MdAUU16HhyNizJBtAXtq+fg@mail.gmail.com>
> > Hi Chris
> >
> > This change in itself makes sense. But i wounder if we should also
> > change phy_init_eee(). It reads the EEE Ability register. The 2018
> > version of the standard indicates the top two bits are reserved and
> > should be zero. We also don't have any PHY which supports 100GBase-R
> > through to 100Base-TX. So a read of 0xffff suggests the PHY does not
> > support EEE and returning -EPROTONOSUPPORT would be good.
> >
> This seems like a good change to make in phy_init_eee(). I should be
> able to do this. Can this be done in a subsequent patch or does this
> need to be present to land this meson specific PHY patch?
They are independent, submit them in whatever order you want. But
doing it first will make it easier to test it actually works.
Andrew
prev parent reply other threads:[~2023-01-29 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 2:26 [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD register access Chris Healy
2023-01-29 10:26 ` Heiner Kallweit
2023-01-29 21:25 ` Chris Healy
2023-01-29 16:51 ` Andrew Lunn
2023-01-29 21:28 ` Chris Healy
2023-01-29 21:53 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9bqzZw4z6JWGeI6@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=healych@amazon.com \
--cc=hkallweit1@gmail.com \
--cc=jeremy.wang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).